Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: No delivery option not parsed correctly. #3563

Closed
islean opened this issue Aug 14, 2024 · 1 comment · Fixed by #4294
Closed

Bug: No delivery option not parsed correctly. #3563

islean opened this issue Aug 14, 2024 · 1 comment · Fixed by #4294
Assignees
@ChrOertlin
Labels
Bug Urgency M

Comments

@islean
Copy link
Contributor

islean commented Aug 14, 2024 •
edited by Vince-janv
Loading

Describe the bug

When uploading an (at least 1508) excel order form with "No delivery" selected as data_delivery, the parsing fails, with an "Unsupported data delivery" error.

To Reproduce

Upload a 1508 form with No delivery selected from the dropdown.

Expected behavior

It should be parsed into the no-delivery option.

Clarification

In the excel orderform the column data delivery is a drop down meny containg the option No delivery since it contains a space it crashes when the excel sheet is uploaded.

The option is only used within the CG org to place control samples
@diitaz93
Copy link
Contributor

diitaz93 commented Feb 3, 2025

The parsing of the panel "Inherited cancer" also gets wrongly parsed in that same orderform

Image

@ChrOertlin ChrOertlin mentioned this issue Mar 17, 2025
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrOertlin ChrOertlin

Labels
Bug Urgency M
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix( parsing no delivery option) Clinical-Genomics/cg
3 participants
@ChrOertlin @diitaz93 @islean