Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix( parsing no delivery option) #4294

Merged
merged 16 commits into from
Mar 18, 2025
Merged

fix( parsing no delivery option) #4294

merged 16 commits into from
Mar 18, 2025

Conversation

ChrOertlin
Copy link
Contributor

@ChrOertlin ChrOertlin commented Mar 17, 2025 •
edited
Loading

Description

closes: #3563

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@clingen-sthlm clingen-sthlm temporarily deployed to stage March 17, 2025 13:30 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage March 17, 2025 13:33 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage March 17, 2025 13:58 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage March 17, 2025 14:04 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage March 17, 2025 14:12 Inactive
@ChrOertlin ChrOertlin marked this pull request as ready for review March 17, 2025 14:13
@ChrOertlin ChrOertlin requested a review from a team as a code owner March 17, 2025 14:14
@ChrOertlin
Copy link
Contributor Author

File with No Delivery could be uploaded

@ChrOertlin ChrOertlin marked this pull request as draft March 17, 2025 14:33
@ChrOertlin ChrOertlin marked this pull request as ready for review March 18, 2025 09:52
Vince-janv
Vince-janv approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch! 💯

islean
islean approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@clingen-sthlm clingen-sthlm temporarily deployed to stage March 18, 2025 12:33 Inactive
@ChrOertlin
Copy link
Contributor Author

image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@clingen-sthlm clingen-sthlm temporarily deployed to stage March 18, 2025 12:48 Inactive
@ChrOertlin ChrOertlin merged commit a661056 into master Mar 18, 2025
10 checks passed
@ChrOertlin ChrOertlin deleted the fix-no-delivery-parse branch March 18, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

@Vince-janv Vince-janv Vince-janv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: No delivery option not parsed correctly.
4 participants
@ChrOertlin @islean @Vince-janv @clingen-sthlm