forked from SMD-Bioinformatics-Lund/gens
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge current lund dev #97
Draft
dnil
wants to merge
221
commits into
master
Choose a base branch
from
merge_current_lund_dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jakob Willforss <[email protected]>
…s-Lund/166-transition-to-newer-python Updated python to version 3.12
…s-Lund/jw/first-typescript JS -> TS
…s-Lund/jw/type-hint-commands-modules Type hint commands modules
…s-Lund/jw/missing-annotations Missing annotations in frontend
…s-Lund/jw/further-mypy-checks Jw/further mypy checks
…s-Lund/jw/fix-genome-build-click Use the custom choice for genome build
…s-Lund/jw/pylint Pylint
…s-Lund/jw/fix-display-samples-error Fix display samples error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges unreleased dev changes from the Lund repo to Solna. Much looking forward to a joint/single repo; we just need to iron out issues with automation etc.
I opted for a hopefully clean merge this time, as we really have very little own edits compared to Lund currently, only last weeks final edits for todays
3.0.1
merge realistically.Tested annotation loading again, since that is part of the diff and extra merge.

But, yes, as per comment below, the path of the app code on the Docker image has changed, so the server configs need an update.


How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: