Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GKR Gate Registry #1442

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

GKR Gate Registry #1442

wants to merge 9 commits into from

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Mar 5, 2025

Companion to Consensys/gnark-crypto#652

  • Implement a GKR Gate registry
  • ... which includes automatic degree detection. However this is not perfect, as it always delegates the degree computation to a BN254 instantiation. If for whatever reason a gate polynomial has a leading coefficient multiple of the BN254 scalar field size, the estimated degree will be lower than the actual value. In the future we should probably use the same field as the frontend api (but that will involve a lot of code generation.)
  • Turn gkr.Gate into a struct, rather than an interface.
  • Add "feed forward" to Poseidon2 GKR for it to compute a compression function, not just a permutation.

@Tabaie Tabaie requested review from ivokub and ThomasPiellard March 5, 2025 22:22
@Tabaie Tabaie marked this pull request as draft March 6, 2025 03:42
@Tabaie Tabaie marked this pull request as ready for review March 11, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub Awaiting requested review from ivokub

@ThomasPiellard ThomasPiellard Awaiting requested review from ThomasPiellard

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tabaie