feat: TRM redesign #106
Open
feat: TRM redesign #106
+268
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F Bojarski <[email protected]>
Open
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
OlivierBBB
requested changes
Mar 19, 2025
| @@ -0,0 +1,25 @@ | |||
| \begin{description} | |||
| \item[\underline{Selector:}] none | |||
There was a problem hiding this comment.
I would have expected IOMF selector or so. I haven't looked in detail but it seems that every row will spawn a lookup to WCP so I get that there may be no need for a selector. A bit of documentation would be nice either way .
There was a problem hiding this comment.
we don't need a selector, during padding it'll lookup into the padding of wcp, so no need for selector
| we impose that | ||
| \[ | ||
| \wcpCallToLeq { | ||
| anchorRow = i - \anchorRow , |
There was a problem hiding this comment.
This would be an argument in favour of not having a DONE column but a FIRST or so column ...
| We fix the target of the accumulator column: | ||
| \[ | ||
| \boxed{\text{All constraints in this subsection assume } \done_{i} = 1 } | ||
| \] |
There was a problem hiding this comment.
It would be worthwhile explaining the approach: trimming a 16 byte high part of an EVM word via
- proposing a decomposition
rawHi = to_be_trimmed * 256^4 + trmHi - verifying that
to_be_trimmed < 256^12trmHi < 256^4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.