profiling: update ffi build script to cross compile 32 bit on 64 bit linux #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taegyunkim
changed the title
taegyunkim
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 71.91% 71.90% -0.02%
==========================================
Files 324 324
Lines 48044 48048 +4
==========================================
- Hits 34549 34547 -2
- Misses 13495 13501 +6
|
BenchmarksComparisonBenchmark execution time: 2025-03-11 19:30:14 Comparing candidate commit dab9ab7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
ivoanjo
approved these changes
Feb 11, 2025
Comment on lines
-31
to
35
| while getopts f:hT flag | ||
| while getopts f:ht:T flag | ||
| do | ||
| case "${flag}" in | ||
| f) |
There was a problem hiding this comment.
Two notes here:
-
I think we're misusing the shift -- it actually breaks if we try to pass more than one setting now; e.g.
-f foo -t tripletor-T -t triplet. My bash-foo isn't great but this suggests how we may fix it. I think it has "worked" until now since nobody tried to use-fwith-T, but it seems reasonable to want to combine-fand-tfor instance? -
As a script UX thing, consider using something other than
-tfor the triplet, to avoid the collision with the test. Maybe-a(arch?) or-c(cpu) or something like that? Alternatively, rename the-Tto something else, I think that works too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.