-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashtracking for Windows #892
Open
kevingosse
wants to merge
53
commits into
main
Choose a base branch
from
kevin/crashtracking_windows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 33 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
622f28f
WIP
kevingosse 9432c74
Checkpoint
kevingosse 6337dac
Checkpoint
kevingosse 7534b60
Checkpoint
kevingosse 2389144
linting
kevingosse d17c84e
Keep trying to please the linter
kevingosse be78818
Warning + license
kevingosse 21a49d7
More clippy
kevingosse 00821c6
Getting there
kevingosse 9f93da2
...
kevingosse 036af55
Conditionally define windows functions
kevingosse cf5ea53
Conditional compilation
kevingosse 14136df
Fix following rebase
kevingosse af91be6
Regenerate license file
kevingosse ea8e7c3
Address PR feedback
kevingosse cd710f2
Add test for WerContext
kevingosse f3f4b5d
lint
kevingosse 0997117
Clippy is a well deserved name
kevingosse 9eaa7b1
...
kevingosse 174bbcb
Fix
kevingosse 0beb9a1
More clippy
kevingosse d556178
Add test for pdb info
kevingosse c01c1c1
Restore version of symbolic-common
kevingosse 26f36f4
Clippy
kevingosse 6c5b6ec
Add integration test, rename callbacks
kevingosse 5573cfe
Lint
kevingosse 86beb13
Update license
kevingosse 8a87c53
Lint
kevingosse b045ec6
Lint?
kevingosse 1448094
Debugging why it fails in the CI
kevingosse a942e57
Try hardcoding the path to see what happens in the CI
kevingosse c62002f
fix compiltion
kevingosse 2fde2f6
More debug
kevingosse 0ae36c5
More debug
kevingosse 1e67828
Compilation error
kevingosse bb22975
Try to log stuff
kevingosse 0a077d7
Change error mode
kevingosse 094f206
CLeanup
kevingosse 0f2ad7e
Fixes
kevingosse 587dd57
Remove extra lib
kevingosse cf53ea7
Update license
kevingosse e2bf2ac
Lint
kevingosse 62a957a
Clippy
kevingosse 9c7b9b7
Use Mutex
kevingosse 7c8a3e2
Newline
kevingosse 95cc74a
Move core logic
kevingosse c2227bc
Clippy
kevingosse df6ea80
Remove duplicated tests
kevingosse 5d91436
Merge branch 'main' into kevin/crashtracking_windows
kevingosse b5164d6
Rename the test
kevingosse 3c3a9de
Make feature conditional on windows
kevingosse 8c0398e
Address PR feedback
kevingosse 17fe93c
Add safety comments
kevingosse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need a test app to crash. The lib is because I need a DLL for WER. Maybe it's possible to reference datadog-crashtracker-ffi as a DLL but I didn't find how (when I reference the crate it gets statically linked)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reorganized the tests and remove test_app_lib (but for that I had to add a
cdylibcrate-type to crashtracker-ffi)