Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style cleanup #913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Style cleanup #913

wants to merge 1 commit into from

Conversation

realFlowControl
Copy link
Member

What does this PR do?

Small style cleanup from #908 (review)

Motivation

Keep everything tidy and clean 😉

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@realFlowControl realFlowControl requested a review from a team as a code owner March 7, 2025 14:07
@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Mar 7, 2025
@realFlowControl realFlowControl mentioned this pull request Mar 7, 2025
Merged
@pr-commenter
Copy link

pr-commenter bot commented Mar 7, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-03-07 14:18:15

Comparing candidate commit 0c4279d in PR branch florian/cleanup with baseline commit 93f1c5b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.616µs 505.796µs ± 0.647µs 505.751µs ± 0.240µs 506.009µs 506.340µs 506.644µs 513.261µs 1.49% 7.667 86.928 0.13% 0.046µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1948326.274op/s 1977084.219op/s ± 2504.430op/s 1977259.321op/s ± 939.282op/s 1978139.960op/s 1979607.263op/s 1980521.160op/s 1981704.246op/s 0.22% -7.552 85.213 0.13% 177.090op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.593µs 453.509µs ± 0.334µs 453.528µs ± 0.230µs 453.731µs 454.052µs 454.290µs 454.389µs 0.19% -0.033 0.086 0.07% 0.024µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2200759.196op/s 2205028.469op/s ± 1622.520op/s 2204934.434op/s ± 1115.773op/s 2206187.285op/s 2207604.021op/s 2209302.062op/s 2209490.158op/s 0.21% 0.038 0.087 0.07% 114.730op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.056µs 176.370µs ± 0.411µs 176.391µs ± 0.265µs 176.642µs 176.999µs 177.227µs 177.701µs 0.74% -0.074 0.452 0.23% 0.029µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5627434.208op/s 5669925.109op/s ± 13203.563op/s 5669219.567op/s ± 8516.874op/s 5678153.489op/s 5693394.686op/s 5699015.405op/s 5712471.258op/s 0.76% 0.091 0.448 0.23% 933.633op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.516µs 37.645µs ± 0.053µs 37.642µs ± 0.031µs 37.672µs 37.736µs 37.776µs 37.864µs 0.59% 0.557 1.243 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26410424.133op/s 26564282.669op/s ± 37304.217op/s 26566320.115op/s ± 21642.847op/s 26587917.994op/s 26621093.419op/s 26638459.683op/s 26655450.714op/s 0.34% -0.545 1.214 0.14% 2637.806op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.229µs 48.338µs ± 0.133µs 48.325µs ± 0.028µs 48.356µs 48.398µs 48.448µs 49.978µs 3.42% 10.192 118.567 0.27% 0.009µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20008808.423op/s 20687641.340op/s ± 55231.488op/s 20693295.960op/s ± 11838.572op/s 20704888.519op/s 20719273.359op/s 20728740.691op/s 20734539.926op/s 0.20% -10.055 116.063 0.27% 3905.456op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.707µs; 505.886µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1976737.129op/s; 1977431.309op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.463µs; 453.555µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2204803.603op/s; 2205253.335op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.313µs; 176.427µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5668095.222op/s; 5671754.996op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.637µs; 37.652µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26559112.663op/s; 26569452.675op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.320µs; 48.357µs] or [-0.038%; +0.038%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20679986.787op/s; 20695295.893op/s] or [-0.037%; +0.037%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.597µs 209.220µs ± 0.320µs 209.215µs ± 0.120µs 209.331µs 209.509µs 209.728µs 211.930µs 1.30% 4.957 38.709 0.15% 0.023µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4718542.751op/s 4779660.376op/s ± 7251.223op/s 4779765.523op/s ± 2750.529op/s 4782929.492op/s 4788254.613op/s 4790776.246op/s 4793940.873op/s 0.30% -4.884 37.970 0.15% 512.739op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.267µs 18.350µs ± 0.037µs 18.360µs ± 0.023µs 18.379µs 18.397µs 18.414µs 18.420µs 0.33% -0.619 -0.515 0.20% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54289244.338op/s 54494848.150op/s ± 109475.955op/s 54467008.481op/s ± 68627.810op/s 54570439.344op/s 54731514.006op/s 54739398.723op/s 54744251.633op/s 0.51% 0.626 -0.507 0.20% 7741.119op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.663µs 10.733µs ± 0.051µs 10.723µs ± 0.037µs 10.767µs 10.829µs 10.894µs 10.901µs 1.66% 0.923 0.535 0.47% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 91731386.396op/s 93176051.691op/s ± 437798.668op/s 93254151.774op/s ± 323316.047op/s 93547621.118op/s 93675479.680op/s 93733455.962op/s 93786603.303op/s 0.57% -0.899 0.457 0.47% 30957.041op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.176µs; 209.265µs] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4778655.426op/s; 4780665.326op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.345µs; 18.356µs] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54479675.835op/s; 54510020.464op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.726µs; 10.740µs] or [-0.065%; +0.065%] None None None
normalization/normalize_name/normalize_name/good throughput [93115377.006op/s; 93236726.376op/s] or [-0.065%; +0.065%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.967ms 5.978ms ± 0.006ms 5.977ms ± 0.003ms 5.981ms 5.987ms 6.004ms 6.013ms 0.61% 1.964 8.130 0.10% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.977ms; 5.979ms] or [-0.014%; +0.014%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 146.925µs 147.593µs ± 0.332µs 147.545µs ± 0.178µs 147.729µs 148.313µs 148.664µs 148.703µs 0.78% 1.068 1.607 0.22% 0.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [147.547µs; 147.639µs] or [-0.031%; +0.031%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.176µs 3.160µs ± 1.407µs 2.969µs ± 0.025µs 2.994µs 3.611µs 13.729µs 14.738µs 396.38% 7.393 55.636 44.42% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.965µs; 3.355µs] or [-6.172%; +6.172%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.409µs 2.431µs ± 0.013µs 2.429µs ± 0.006µs 2.434µs 2.471µs 2.478µs 2.479µs 2.03% 2.080 4.581 0.55% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.429µs; 2.433µs] or [-0.077%; +0.077%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.991µs 5.060µs ± 0.036µs 5.060µs ± 0.030µs 5.086µs 5.114µs 5.117µs 5.144µs 1.66% -0.115 -1.090 0.71% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.055µs; 5.065µs] or [-0.098%; +0.098%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.606µs 25.346µs ± 10.367µs 17.819µs ± 0.107µs 34.417µs 43.897µs 44.903µs 75.768µs 325.21% 1.439 2.972 40.80% 0.733µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.909µs; 26.783µs] or [-5.669%; +5.669%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 53.619ms 54.108ms ± 0.310ms 54.146ms ± 0.209ms 54.254ms 54.547ms 54.963ms 55.633ms 2.75% 1.098 3.393 0.57% 0.022ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [54.065ms; 54.151ms] or [-0.079%; +0.079%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.602ns 253.044ns ± 11.939ns 248.072ns ± 1.679ns 252.101ns 282.142ns 294.480ns 295.382ns 19.07% 2.148 3.454 4.71% 0.844ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.389ns; 254.699ns] or [-0.654%; +0.654%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.896µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.921µs 3.923µs 0.22% -1.369 12.418 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254923821.179op/s 255468152.860op/s ± 171129.418op/s 255479612.727op/s ± 74865.927op/s 255545174.000op/s 255676997.592op/s 255847501.876op/s 256686378.774op/s 0.47% 1.394 12.593 0.07% 12100.677op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 82.135µs 82.495µs ± 0.205µs 82.434µs ± 0.119µs 82.586µs 82.902µs 83.149µs 83.192µs 0.92% 1.167 1.122 0.25% 0.014µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12020314.331op/s 12122062.497op/s ± 30042.890op/s 12130899.968op/s ± 17466.600op/s 12145503.442op/s 12153062.325op/s 12163382.797op/s 12175012.005op/s 0.36% -1.154 1.082 0.25% 2124.353op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.453µs 77.061µs ± 0.350µs 77.022µs ± 0.226µs 77.268µs 77.679µs 78.050µs 78.469µs 1.88% 0.858 1.289 0.45% 0.025µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12743827.405op/s 12976966.213op/s ± 58685.291op/s 12983229.562op/s ± 37907.366op/s 13018090.592op/s 13059270.874op/s 13077190.839op/s 13079984.103op/s 0.75% -0.824 1.178 0.45% 4149.677op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.915µs ± 0.006µs 3.914µs ± 0.002µs 3.917µs 3.919µs 3.921µs 3.970µs 1.43% 6.807 61.048 0.16% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 251870428.628op/s 255414034.393op/s ± 395427.891op/s 255463965.442op/s ± 100345.006op/s 255544387.238op/s 255666790.401op/s 255824692.198op/s 256885945.354op/s 0.56% -6.729 60.324 0.15% 27960.974op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 73.067µs 74.077µs ± 0.500µs 74.035µs ± 0.331µs 74.391µs 74.910µs 75.455µs 76.005µs 2.66% 0.609 0.894 0.67% 0.035µs 1 200
credit_card/is_card_number/378282246310005 throughput 13156982.048op/s 13500018.889op/s ± 90712.903op/s 13507048.546op/s ± 60748.965op/s 13563715.708op/s 13635286.720op/s 13675028.979op/s 13685986.315op/s 1.32% -0.559 0.759 0.67% 6414.371op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.970µs 52.159µs ± 0.079µs 52.162µs ± 0.054µs 52.207µs 52.302µs 52.361µs 52.386µs 0.43% 0.249 0.037 0.15% 0.006µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19089001.275op/s 19172223.745op/s ± 29177.350op/s 19171179.965op/s ± 19743.688op/s 19192414.678op/s 19217808.284op/s 19237195.699op/s 19241768.106op/s 0.37% -0.240 0.029 0.15% 2063.150op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.431µs 6.576µs ± 0.072µs 6.568µs ± 0.051µs 6.630µs 6.711µs 6.728µs 6.759µs 2.90% 0.304 -0.478 1.09% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 147957979.934op/s 152075391.936op/s ± 1655439.386op/s 152254137.300op/s ± 1194417.011op/s 153377218.241op/s 154567949.569op/s 155318598.118op/s 155501084.049op/s 2.13% -0.258 -0.502 1.09% 117057.242op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.916µs 3.918µs 3.921µs 3.928µs 0.35% -0.992 10.249 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254581672.989op/s 255483003.779op/s ± 200465.944op/s 255471004.042op/s ± 91340.407op/s 255566108.563op/s 255797808.765op/s 255900992.786op/s 256809910.310op/s 0.52% 1.019 10.373 0.08% 14175.083op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.508µs 63.961µs ± 0.180µs 63.938µs ± 0.092µs 64.026µs 64.368µs 64.536µs 64.688µs 1.17% 1.115 2.127 0.28% 0.013µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15458887.728op/s 15634572.973op/s ± 43965.664op/s 15640198.917op/s ± 22517.735op/s 15663007.500op/s 15692722.343op/s 15718460.988op/s 15746014.578op/s 0.68% -1.091 2.068 0.28% 3108.842op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.428µs 57.548µs ± 0.137µs 57.526µs ± 0.028µs 57.564µs 57.645µs 57.877µs 59.181µs 2.88% 8.874 99.321 0.24% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16897405.267op/s 17376751.056op/s ± 40576.963op/s 17383464.848op/s ± 8336.657op/s 17391078.377op/s 17401646.982op/s 17406961.710op/s 17413241.028op/s 0.17% -8.714 96.568 0.23% 2869.225op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.897µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.916µs 3.919µs 3.920µs 3.929µs 0.37% -0.400 8.369 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254534854.738op/s 255478383.474op/s ± 190919.552op/s 255475461.582op/s ± 85436.050op/s 255575298.876op/s 255762306.287op/s 255881880.428op/s 256622672.869op/s 0.45% 0.423 8.422 0.07% 13500.051op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.591µs 54.850µs ± 0.285µs 54.696µs ± 0.048µs 55.089µs 55.531µs 55.674µs 56.312µs 2.95% 1.722 3.429 0.52% 0.020µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17758100.896op/s 18232154.722op/s ± 93957.768op/s 18282838.817op/s ± 16042.206op/s 18295293.538op/s 18302589.552op/s 18311550.796op/s 18318085.446op/s 0.19% -1.685 3.186 0.51% 6643.817op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.012µs 52.207µs ± 0.086µs 52.198µs ± 0.060µs 52.268µs 52.351µs 52.425µs 52.518µs 0.61% 0.363 0.200 0.16% 0.006µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19041143.548op/s 19154734.339op/s ± 31531.053op/s 19157826.918op/s ± 21919.948op/s 19175532.501op/s 19203755.488op/s 19213473.372op/s 19226397.844op/s 0.36% -0.353 0.182 0.16% 2229.582op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.476µs 6.633µs ± 0.074µs 6.634µs ± 0.048µs 6.680µs 6.753µs 6.803µs 6.813µs 2.70% 0.144 -0.509 1.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 146781908.192op/s 150791471.218op/s ± 1686250.037op/s 150745633.275op/s ± 1093387.086op/s 151937118.189op/s 153552242.995op/s 154208488.098op/s 154419338.021op/s 2.44% -0.095 -0.535 1.12% 119235.884op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.915µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255444435.968op/s; 255491869.751op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.466µs; 82.523µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12117898.842op/s; 12126226.153op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [77.013µs; 77.110µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12968832.996op/s; 12985099.430op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.916µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number/37828224631 throughput [255359231.890op/s; 255468836.895op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/378282246310005 execution_time [74.008µs; 74.147µs] or [-0.093%; +0.093%] None None None
credit_card/is_card_number/378282246310005 throughput [13487446.953op/s; 13512590.825op/s] or [-0.093%; +0.093%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.148µs; 52.170µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19168180.045op/s; 19176267.446op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.567µs; 6.586µs] or [-0.151%; +0.151%] None None None
credit_card/is_card_number/x371413321323331 throughput [151845963.958op/s; 152304819.913op/s] or [-0.151%; +0.151%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.915µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255455221.127op/s; 255510786.431op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.936µs; 63.986µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15628479.755op/s; 15640666.192op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.529µs; 57.567µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17371127.479op/s; 17382374.633op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.914µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255451923.860op/s; 255504843.088op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.810µs; 54.889µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18219133.079op/s; 18245176.365op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.195µs; 52.218µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19150364.438op/s; 19159104.240op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.622µs; 6.643µs] or [-0.155%; +0.155%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [150557773.180op/s; 151025169.255op/s] or [-0.155%; +0.155%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.695µs 67.896µs ± 0.209µs 67.867µs ± 0.044µs 67.916µs 68.028µs 68.391µs 70.411µs 3.75% 9.353 105.976 0.31% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.867µs; 67.925µs] or [-0.043%; +0.043%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 0c4279d 1741356406 florian/cleanup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.531µs 33.223µs ± 1.034µs 32.777µs ± 0.118µs 32.909µs 35.425µs 35.462µs 36.413µs 11.09% 1.684 0.979 3.10% 0.073µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.079µs; 33.366µs] or [-0.431%; +0.431%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.19%. Comparing base (8fdbf3b) to head (0c4279d).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
- Coverage   72.24%   72.19%   -0.05%     
==========================================
  Files         330      330              
  Lines       49128    49161      +33     
==========================================
  Hits        35494    35494              
- Misses      13634    13667      +33
Components Coverage Δ
crashtracker 42.87% <ø> (ø)
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.33% <ø> (ø)
data-pipeline-ffi 90.39% <ø> (ø)
ddcommon 79.19% <ø> (ø)
ddcommon-ffi 61.05% <ø> (ø)
ddtelemetry 61.74% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.59% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.40% <ø> (-0.24%) ⬇️
profiling 81.97% <25.00%> (-0.03%) ⬇️
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.88% <ø> (ø)
sidecar-ffi 5.14% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 92.00% <ø> (ø)
trace-mini-agent 74.94% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 78.13% <ø> (ø)
trace-utils 93.77% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ivoanjo
ivoanjo approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Simple && clean!

@realFlowControl realFlowControl enabled auto-merge (squash) March 7, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

@morrisonlevi morrisonlevi Awaiting requested review from morrisonlevi

Assignees
No one assigned
Labels
profiling Relates to the profiling* modules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realFlowControl @codecov-commenter @ivoanjo