Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsn/experimental profile mutex #918

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

dsn/experimental profile mutex #918

wants to merge 3 commits into from

Conversation

danielsn
Copy link
Contributor

  • [profiler] Optionally take a mutex on the FFI
  • [Profiler] R&D week experiment adding a lock to the API

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested review from a team as code owners March 12, 2025 15:15
@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Mar 12, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-03-12 17:34:42

Comparing candidate commit f84ae26 in PR branch dsn/experimental-profile-mutex with baseline commit 4ba2f3a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.467µs 505.470µs ± 0.569µs 505.479µs ± 0.220µs 505.685µs 505.924µs 506.192µs 512.000µs 1.29% 7.501 85.294 0.11% 0.040µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1953123.878op/s 1978359.850op/s ± 2206.694op/s 1978320.977op/s ± 859.961op/s 1979249.721op/s 1980728.664op/s 1982011.562op/s 1982290.681op/s 0.20% -7.397 83.767 0.11% 156.037op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.656µs 453.312µs ± 0.252µs 453.278µs ± 0.136µs 453.436µs 453.763µs 454.015µs 454.142µs 0.19% 0.629 0.603 0.06% 0.018µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2201956.152op/s 2205984.946op/s ± 1228.240op/s 2206153.093op/s ± 660.908op/s 2206770.659op/s 2207750.784op/s 2208234.941op/s 2209184.841op/s 0.14% -0.625 0.598 0.06% 86.850op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.874µs 176.835µs ± 0.444µs 176.854µs ± 0.182µs 177.026µs 177.178µs 177.243µs 181.776µs 2.78% 6.665 74.733 0.25% 0.031µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5501274.820op/s 5655012.203op/s ± 13981.577op/s 5654381.191op/s ± 5823.433op/s 5660545.834op/s 5672714.050op/s 5680006.476op/s 5685880.876op/s 0.56% -6.424 71.436 0.25% 988.647op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.549µs 37.644µs ± 0.044µs 37.638µs ± 0.023µs 37.663µs 37.710µs 37.769µs 37.989µs 0.93% 2.747 18.201 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26323216.036op/s 26564851.307op/s ± 30907.381op/s 26568669.468op/s ± 16264.374op/s 26583946.288op/s 26601259.738op/s 26619782.000op/s 26631785.221op/s 0.24% -2.703 17.771 0.12% 2185.482op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.113µs 48.301µs ± 0.078µs 48.324µs ± 0.031µs 48.346µs 48.393µs 48.419µs 48.543µs 0.45% -0.805 0.294 0.16% 0.006µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20600162.320op/s 20703451.969op/s ± 33610.044op/s 20693797.176op/s ± 13170.558op/s 20719960.958op/s 20778981.098op/s 20781226.671op/s 20784334.658op/s 0.44% 0.813 0.294 0.16% 2376.589op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.391µs; 505.549µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1978054.023op/s; 1978665.676op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.277µs; 453.347µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2205814.723op/s; 2206155.168op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.774µs; 176.897µs] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5653074.491op/s; 5656949.915op/s] or [-0.034%; +0.034%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.638µs; 37.650µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26560567.841op/s; 26569134.773op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.290µs; 48.312µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20698793.940op/s; 20708109.998op/s] or [-0.022%; +0.022%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 54.569ms 54.981ms ± 0.288ms 54.897ms ± 0.094ms 55.082ms 55.520ms 56.107ms 56.770ms 3.41% 2.633 10.180 0.52% 0.020ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [54.941ms; 55.021ms] or [-0.072%; +0.072%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.356µs 2.398µs ± 0.016µs 2.396µs ± 0.007µs 2.402µs 2.438µs 2.444µs 2.447µs 2.09% 0.961 2.067 0.66% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.395µs; 2.400µs] or [-0.092%; +0.092%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.988µs 5.053µs ± 0.039µs 5.058µs ± 0.037µs 5.085µs 5.110µs 5.113µs 5.113µs 1.09% -0.031 -1.579 0.76% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.048µs; 5.058µs] or [-0.106%; +0.106%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 146.574µs 147.641µs ± 1.040µs 147.494µs ± 0.198µs 147.799µs 148.230µs 148.684µs 161.297µs 9.36% 11.439 147.416 0.70% 0.074µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [147.497µs; 147.785µs] or [-0.098%; +0.098%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.458µs 33.935µs ± 0.664µs 33.625µs ± 0.059µs 33.794µs 35.236µs 35.271µs 37.947µs 12.85% 2.244 6.158 1.95% 0.047µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.843µs; 34.027µs] or [-0.271%; +0.271%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.461µs 25.606µs ± 11.319µs 17.900µs ± 0.329µs 34.111µs 43.316µs 54.255µs 107.407µs 500.04% 2.609 13.592 44.09% 0.800µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.037µs; 27.175µs] or [-6.126%; +6.126%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.913µs ± 0.002µs 3.912µs ± 0.001µs 3.913µs 3.915µs 3.918µs 3.929µs 0.43% -1.259 34.313 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 254513736.924op/s 255587161.462op/s ± 159735.373op/s 255603586.349op/s ± 60377.816op/s 255651477.350op/s 255727729.837op/s 255782751.349op/s 256946705.415op/s 0.53% 1.324 34.568 0.06% 11294.997op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.935µs 82.373µs ± 0.235µs 82.318µs ± 0.134µs 82.478µs 82.769µs 83.065µs 83.586µs 1.54% 1.373 3.333 0.28% 0.017µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11963674.362op/s 12139968.628op/s ± 34470.243op/s 12147969.647op/s ± 19749.394op/s 12163283.308op/s 12180142.228op/s 12192903.220op/s 12204778.171op/s 0.47% -1.344 3.177 0.28% 2437.414op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.534µs 77.341µs ± 0.288µs 77.326µs ± 0.186µs 77.516µs 77.868µs 78.065µs 78.099µs 1.00% 0.224 0.198 0.37% 0.020µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12804225.946op/s 12930008.181op/s ± 48163.039op/s 12932256.962op/s ± 31118.504op/s 12962300.446op/s 13004380.859op/s 13032977.995op/s 13066105.347op/s 1.03% -0.200 0.191 0.37% 3405.641op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.913µs ± 0.002µs 3.912µs ± 0.001µs 3.913µs 3.917µs 3.918µs 3.919µs 0.19% -2.245 24.404 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255135958.718op/s 255586784.722op/s ± 150018.856op/s 255608550.107op/s ± 60453.212op/s 255663730.578op/s 255729158.569op/s 255741872.837op/s 256854322.398op/s 0.49% 2.283 24.748 0.06% 10607.935op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.877µs 73.722µs ± 0.482µs 73.655µs ± 0.301µs 73.970µs 74.515µs 74.801µs 76.348µs 3.66% 1.067 3.324 0.65% 0.034µs 1 200
credit_card/is_card_number/378282246310005 throughput 13097925.096op/s 13564953.664op/s ± 88010.668op/s 13576847.427op/s ± 55484.837op/s 13629835.399op/s 13688485.493op/s 13713216.840op/s 13721773.882op/s 1.07% -0.988 2.881 0.65% 6223.294op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.024µs 52.176µs ± 0.073µs 52.176µs ± 0.051µs 52.226µs 52.291µs 52.355µs 52.384µs 0.40% 0.102 -0.298 0.14% 0.005µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19089952.153op/s 19166001.667op/s ± 26917.690op/s 19165755.587op/s ± 18579.625op/s 19184821.931op/s 19210328.435op/s 19220333.711op/s 19221735.939op/s 0.29% -0.095 -0.304 0.14% 1903.368op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.432µs 6.562µs ± 0.069µs 6.555µs ± 0.045µs 6.604µs 6.684µs 6.718µs 6.725µs 2.58% 0.203 -0.494 1.04% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 148708028.353op/s 152409979.241op/s ± 1589885.987op/s 152547403.337op/s ± 1044755.936op/s 153558222.991op/s 154789801.085op/s 155446173.429op/s 155472161.619op/s 1.92% -0.157 -0.524 1.04% 112421.916op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.897µs 3.913µs ± 0.002µs 3.912µs ± 0.001µs 3.914µs 3.916µs 3.919µs 3.919µs 0.18% -1.626 16.872 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255138480.004op/s 255573560.712op/s ± 134949.545op/s 255591539.920op/s ± 66430.525op/s 255650682.749op/s 255725402.626op/s 255766788.848op/s 256613804.156op/s 0.40% 1.652 17.077 0.05% 9542.374op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.591µs 63.863µs ± 0.130µs 63.849µs ± 0.047µs 63.892µs 64.055µs 64.348µs 64.664µs 1.28% 2.167 9.075 0.20% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15464456.228op/s 15658525.166op/s ± 31758.505op/s 15661892.269op/s ± 11625.711op/s 15674552.756op/s 15701973.817op/s 15711386.788op/s 15725596.554op/s 0.41% -2.128 8.829 0.20% 2245.665op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.465µs 57.722µs ± 0.142µs 57.725µs ± 0.105µs 57.836µs 57.918µs 57.982µs 58.254µs 0.92% -0.064 -0.161 0.25% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17166125.276op/s 17324583.374op/s ± 42661.817op/s 17323389.909op/s ± 31503.967op/s 17344045.942op/s 17394857.037op/s 17398878.156op/s 17401768.020op/s 0.45% 0.077 -0.189 0.25% 3016.646op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.912µs ± 0.002µs 3.912µs ± 0.001µs 3.913µs 3.915µs 3.917µs 3.919µs 0.20% -2.761 29.892 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255147579.975op/s 255632899.087op/s ± 123144.695op/s 255648397.378op/s ± 52103.442op/s 255692361.191op/s 255750847.105op/s 255796087.310op/s 256721469.053op/s 0.42% 2.796 30.218 0.05% 8707.645op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.599µs 54.805µs ± 0.260µs 54.661µs ± 0.037µs 55.059µs 55.381µs 55.545µs 55.667µs 1.84% 1.448 1.130 0.47% 0.018µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17963973.105op/s 18246923.010op/s ± 85870.546op/s 18294425.691op/s ± 12321.261op/s 18304365.134op/s 18309403.344op/s 18311488.793op/s 18315450.914op/s 0.11% -1.434 1.067 0.47% 6071.965op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.941µs 52.173µs ± 0.077µs 52.171µs ± 0.051µs 52.221µs 52.298µs 52.360µs 52.398µs 0.43% 0.133 0.111 0.15% 0.005µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19084701.683op/s 19167197.166op/s ± 28289.817op/s 19167619.184op/s ± 18588.708op/s 19186999.369op/s 19206809.011op/s 19233988.872op/s 19252603.890op/s 0.44% -0.124 0.110 0.15% 2000.392op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.432µs 6.565µs ± 0.071µs 6.556µs ± 0.042µs 6.600µs 6.704µs 6.722µs 6.762µs 3.15% 0.280 -0.270 1.07% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 147877002.501op/s 152350862.744op/s ± 1633270.249op/s 152535205.827op/s ± 973009.874op/s 153489351.329op/s 154953368.066op/s 155437303.648op/s 155473240.714op/s 1.93% -0.227 -0.311 1.07% 115489.647op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255565023.676op/s; 255609299.248op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.341µs; 82.406µs] or [-0.040%; +0.040%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12135191.383op/s; 12144745.872op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [77.301µs; 77.380µs] or [-0.052%; +0.052%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12923333.247op/s; 12936683.115op/s] or [-0.052%; +0.052%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [255565993.551op/s; 255607575.892op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [73.656µs; 73.789µs] or [-0.091%; +0.091%] None None None
credit_card/is_card_number/378282246310005 throughput [13552756.232op/s; 13577151.096op/s] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.166µs; 52.186µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19162271.134op/s; 19169732.200op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.552µs; 6.571µs] or [-0.145%; +0.145%] None None None
credit_card/is_card_number/x371413321323331 throughput [152189636.334op/s; 152630322.148op/s] or [-0.145%; +0.145%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ throughput [255554858.003op/s; 255592263.421op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.845µs; 63.881µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15654123.743op/s; 15662926.589op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.702µs; 57.741µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17318670.856op/s; 17330495.892op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.912µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255615832.416op/s; 255649965.757op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.769µs; 54.841µs] or [-0.066%; +0.066%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18235022.178op/s; 18258823.842op/s] or [-0.065%; +0.065%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.162µs; 52.183µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19163276.469op/s; 19171117.863op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.555µs; 6.574µs] or [-0.149%; +0.149%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [152124507.196op/s; 152577218.293op/s] or [-0.149%; +0.149%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.639µs 208.951µs ± 0.168µs 208.928µs ± 0.083µs 209.029µs 209.131µs 209.464µs 210.207µs 0.61% 3.295 20.271 0.08% 0.012µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4757209.220op/s 4785816.575op/s ± 3831.432op/s 4786349.014op/s ± 1901.497op/s 4787982.324op/s 4789994.341op/s 4791064.219op/s 4792960.100op/s 0.14% -3.267 20.024 0.08% 270.923op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.253µs 18.302µs ± 0.031µs 18.298µs ± 0.016µs 18.320µs 18.341µs 18.363µs 18.552µs 1.39% 2.801 20.190 0.17% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53903487.225op/s 54637759.683op/s ± 91701.899op/s 54650768.416op/s ± 46830.978op/s 54679491.246op/s 54763182.746op/s 54781345.641op/s 54786488.883op/s 0.25% -2.729 19.472 0.17% 6484.303op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.655µs 10.708µs ± 0.025µs 10.705µs ± 0.015µs 10.724µs 10.740µs 10.779µs 10.831µs 1.18% 0.689 2.977 0.23% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 92327169.079op/s 93387979.474op/s ± 214487.576op/s 93413245.270op/s ± 133473.894op/s 93520978.813op/s 93763789.151op/s 93840809.536op/s 93855117.732op/s 0.47% -0.659 2.854 0.23% 15166.562op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [208.928µs; 208.974µs] or [-0.011%; +0.011%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4785285.576op/s; 4786347.575op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.298µs; 18.307µs] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54625050.682op/s; 54650468.685op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.705µs; 10.711µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good throughput [93358253.559op/s; 93417705.390op/s] or [-0.032%; +0.032%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.952ms 5.963ms ± 0.009ms 5.962ms ± 0.003ms 5.964ms 5.970ms 6.010ms 6.030ms 1.15% 4.702 27.503 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.962ms; 5.964ms] or [-0.021%; +0.021%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.757µs 67.990µs ± 0.189µs 67.986µs ± 0.078µs 68.050µs 68.118µs 68.399µs 70.128µs 3.15% 7.623 81.800 0.28% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.964µs; 68.017µs] or [-0.038%; +0.038%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.180µs 3.196µs ± 1.423µs 3.006µs ± 0.026µs 3.030µs 3.664µs 13.869µs 14.906µs 395.81% 7.380 55.524 44.41% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.999µs; 3.393µs] or [-6.171%; +6.171%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f84ae26 1741800190 dsn/experimental-profile-mutex
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.809ns 253.750ns ± 11.106ns 249.650ns ± 2.742ns 254.073ns 286.597ns 289.972ns 290.453ns 16.34% 2.204 3.993 4.37% 0.785ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.211ns; 255.290ns] or [-0.607%; +0.607%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 47.05882% with 54 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (9393721) to head (f84ae26).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   72.54%   72.41%   -0.13%     
==========================================
  Files         333      333              
  Lines       49996    50119     +123     
==========================================
+ Hits        36269    36295      +26     
- Misses      13727    13824      +97
Components Coverage Δ
crashtracker 42.87% <ø> (-0.03%) ⬇️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.08% <ø> (ø)
data-pipeline-ffi 90.28% <ø> (ø)
ddcommon 79.19% <ø> (ø)
ddcommon-ffi 61.05% <ø> (ø)
ddtelemetry 61.74% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.59% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.40% <ø> (ø)
profiling 81.67% <47.05%> (-0.28%) ⬇️
profiling-ffi 69.63% <47.05%> (-1.06%) ⬇️
serverless 0.00% <ø> (ø)
sidecar 40.63% <ø> (-0.25%) ⬇️
sidecar-ffi 3.23% <ø> (-1.92%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 91.21% <ø> (ø)
trace-mini-agent 74.66% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 96.07% <ø> (+0.10%) ⬆️
trace-protobuf 78.13% <ø> (ø)
trace-utils 92.97% <ø> (-1.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielsn danielsn requested a review from a team as a code owner March 12, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
profiling Relates to the profiling* modules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielsn @codecov-commenter