Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework span links vector decoding #922

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Rework span links vector decoding #922

wants to merge 10 commits into from
+25 −15

Conversation

anais-raison
Copy link
Contributor

@anais-raison anais-raison commented Mar 13, 2025 •
edited
Loading

What does this PR do?

Change the decoding of the vector of span link to use read_array_len to let us handle more than just FixArray.

Motivation

What inspired you to submit this pull request?

Additional Notes

To merge after #912

How to test the change?

Describe here in detail how the change can be validated.

@anais-raison anais-raison requested review from a team as code owners March 13, 2025 11:04
@pr-commenter
Copy link

pr-commenter bot commented Mar 13, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-03-14 16:58:25

Comparing candidate commit 44b561d in PR branch anais/rework-span-links with baseline commit 78f2dfb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.410µs 33.994µs ± 1.122µs 33.481µs ± 0.034µs 33.534µs 36.408µs 36.458µs 37.345µs 11.54% 1.721 1.015 3.29% 0.079µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.839µs; 34.150µs] or [-0.458%; +0.458%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.815µs 69.034µs ± 0.288µs 68.975µs ± 0.059µs 69.064µs 69.326µs 69.647µs 72.492µs 5.10% 9.007 102.291 0.42% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.995µs; 69.074µs] or [-0.058%; +0.058%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 146.847µs 147.855µs ± 0.338µs 147.915µs ± 0.193µs 148.071µs 148.267µs 148.425µs 149.075µs 0.78% -0.446 0.978 0.23% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [147.808µs; 147.902µs] or [-0.032%; +0.032%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.195µs 3.193µs ± 1.419µs 2.978µs ± 0.025µs 3.007µs 3.638µs 13.932µs 14.769µs 395.95% 7.330 54.934 44.32% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.997µs; 3.390µs] or [-6.158%; +6.158%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.721µs 209.078µs ± 0.147µs 209.069µs ± 0.104µs 209.172µs 209.339µs 209.422µs 209.454µs 0.18% 0.227 -0.365 0.07% 0.010µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4774312.290op/s 4782905.462op/s ± 3354.399op/s 4783101.621op/s ± 2374.961op/s 4785525.063op/s 4787978.535op/s 4789489.185op/s 4791094.952op/s 0.17% -0.224 -0.367 0.07% 237.192op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.252µs 18.335µs ± 0.150µs 18.325µs ± 0.038µs 18.364µs 18.405µs 18.427µs 20.326µs 10.92% 11.859 155.490 0.81% 0.011µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 49197196.835op/s 54543114.571op/s ± 406498.103op/s 54571322.808op/s ± 113529.085op/s 54680878.487op/s 54779386.379op/s 54787637.500op/s 54788945.156op/s 0.40% -11.438 148.105 0.74% 28743.757op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.665µs 10.724µs ± 0.026µs 10.724µs ± 0.015µs 10.740µs 10.766µs 10.779µs 10.829µs 0.98% 0.155 0.812 0.24% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 92341875.194op/s 93249362.560op/s ± 224716.838op/s 93247717.587op/s ± 134541.477op/s 93380825.876op/s 93646094.587op/s 93741734.728op/s 93761675.132op/s 0.55% -0.135 0.775 0.24% 15889.880op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.058µs; 209.098µs] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4782440.574op/s; 4783370.349op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.314µs; 18.356µs] or [-0.113%; +0.113%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54486777.843op/s; 54599451.298op/s] or [-0.103%; +0.103%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.720µs; 10.728µs] or [-0.033%; +0.033%] None None None
normalization/normalize_name/normalize_name/good throughput [93218218.968op/s; 93280506.153op/s] or [-0.033%; +0.033%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.977ms 5.993ms ± 0.011ms 5.992ms ± 0.003ms 5.995ms 6.001ms 6.023ms 6.117ms 2.09% 7.771 82.193 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.991ms; 5.994ms] or [-0.025%; +0.025%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.543µs 505.623µs ± 0.437µs 505.616µs ± 0.254µs 505.872µs 506.200µs 506.370µs 509.112µs 0.69% 2.458 18.728 0.09% 0.031µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1964205.412op/s 1977757.821op/s ± 1705.022op/s 1977783.992op/s ± 993.662op/s 1978776.414op/s 1980009.310op/s 1980708.687op/s 1981992.934op/s 0.21% -2.420 18.360 0.09% 120.563op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.481µs 453.424µs ± 0.321µs 453.430µs ± 0.197µs 453.590µs 454.001µs 454.178µs 454.968µs 0.34% 0.521 2.471 0.07% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2197957.504op/s 2205442.730op/s ± 1558.613op/s 2205410.622op/s ± 956.767op/s 2206426.294op/s 2207795.968op/s 2209167.799op/s 2210036.083op/s 0.21% -0.512 2.446 0.07% 110.211op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 176.047µs 176.675µs ± 0.257µs 176.663µs ± 0.175µs 176.852µs 177.108µs 177.240µs 177.341µs 0.38% 0.078 -0.337 0.15% 0.018µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5638865.592op/s 5660122.567op/s ± 8237.204op/s 5660487.026op/s ± 5600.464op/s 5665514.128op/s 5673310.151op/s 5677586.704op/s 5680292.627op/s 0.35% -0.070 -0.338 0.15% 582.458op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.540µs 37.650µs ± 0.045µs 37.648µs ± 0.027µs 37.672µs 37.735µs 37.769µs 37.826µs 0.47% 0.635 0.816 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26436744.862op/s 26560208.307op/s ± 31948.008op/s 26561751.866op/s ± 18796.997op/s 26582158.085op/s 26605721.445op/s 26614546.925op/s 26638004.999op/s 0.29% -0.626 0.796 0.12% 2259.065op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.217µs 48.323µs ± 0.042µs 48.322µs ± 0.026µs 48.345µs 48.392µs 48.429µs 48.545µs 0.46% 0.794 3.052 0.09% 0.003µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20599651.164op/s 20694246.526op/s ± 18165.428op/s 20694534.450op/s ± 10976.700op/s 20706262.374op/s 20722504.244op/s 20730787.103op/s 20739768.695op/s 0.22% -0.783 3.000 0.09% 1284.490op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.563µs; 505.684µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1977521.522op/s; 1977994.121op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.379µs; 453.468µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2205226.721op/s; 2205658.738op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.639µs; 176.711µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5658980.969op/s; 5661264.164op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.644µs; 37.657µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26555780.620op/s; 26564635.993op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.317µs; 48.329µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20691728.972op/s; 20696764.079op/s] or [-0.012%; +0.012%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 245.784ns 253.204ns ± 10.119ns 248.822ns ± 2.355ns 256.530ns 275.475ns 293.623ns 293.962ns 18.14% 2.394 5.764 3.99% 0.716ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.802ns; 254.606ns] or [-0.554%; +0.554%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.985µs 5.055µs ± 0.041µs 5.036µs ± 0.021µs 5.095µs 5.125µs 5.134µs 5.138µs 2.02% 0.405 -1.028 0.81% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.049µs; 5.061µs] or [-0.112%; +0.112%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.345µs 2.397µs ± 0.015µs 2.398µs ± 0.006µs 2.405µs 2.420µs 2.429µs 2.440µs 1.76% -0.890 2.493 0.64% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.395µs; 2.399µs] or [-0.088%; +0.088%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.901µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.919µs 3.922µs 3.925µs 0.28% 0.173 4.234 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254800207.628op/s 255501668.142op/s ± 178432.255op/s 255516548.302op/s ± 88481.921op/s 255604326.104op/s 255718291.454op/s 255966768.695op/s 256363013.236op/s 0.33% -0.160 4.250 0.07% 12617.066op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 82.039µs 82.539µs ± 0.213µs 82.493µs ± 0.106µs 82.640µs 82.852µs 83.060µs 84.139µs 2.00% 2.419 14.746 0.26% 0.015µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11885114.586op/s 12115617.746op/s ± 31127.898op/s 12122291.866op/s ± 15600.360op/s 12132327.395op/s 12152573.855op/s 12169175.384op/s 12189367.215op/s 0.55% -2.337 13.982 0.26% 2201.075op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.567µs 77.130µs ± 0.265µs 77.111µs ± 0.188µs 77.302µs 77.599µs 77.822µs 77.971µs 1.11% 0.558 0.147 0.34% 0.019µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12825249.562op/s 12965332.396op/s ± 44452.770op/s 12968240.135op/s ± 31605.060op/s 12998496.743op/s 13028228.747op/s 13044066.042op/s 13060513.276op/s 0.71% -0.539 0.116 0.34% 3143.286op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.919µs 3.920µs 0.16% -1.828 10.646 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255118470.328op/s 255528054.916op/s ± 175164.093op/s 255522396.543op/s ± 89562.607op/s 255604682.898op/s 255794252.925op/s 255974840.008op/s 256739099.918op/s 0.48% 1.847 10.794 0.07% 12385.972op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 73.087µs 73.975µs ± 0.447µs 73.915µs ± 0.310µs 74.265µs 74.790µs 75.133µs 75.586µs 2.26% 0.592 0.158 0.60% 0.032µs 1 200
credit_card/is_card_number/378282246310005 throughput 13230003.118op/s 13518635.923op/s ± 81482.632op/s 13529128.350op/s ± 56461.883op/s 13580539.825op/s 13633935.963op/s 13650464.374op/s 13682362.348op/s 1.13% -0.559 0.086 0.60% 5761.692op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.906µs 52.148µs ± 0.086µs 52.145µs ± 0.053µs 52.199µs 52.302µs 52.353µs 52.445µs 0.58% 0.271 0.398 0.16% 0.006µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19067596.517op/s 19176103.096op/s ± 31585.848op/s 19177436.788op/s ± 19498.762op/s 19195725.592op/s 19224733.389op/s 19247165.897op/s 19265730.820op/s 0.46% -0.260 0.390 0.16% 2233.457op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.446µs 6.609µs ± 0.061µs 6.602µs ± 0.044µs 6.651µs 6.707µs 6.748µs 6.800µs 3.00% -0.015 0.070 0.93% 0.004µs 1 200
credit_card/is_card_number/x371413321323331 throughput 147049031.680op/s 151332605.221op/s ± 1405378.765op/s 151465748.957op/s ± 1013136.306op/s 152407188.109op/s 153522934.478op/s 154632637.880op/s 155139034.271op/s 2.43% 0.072 0.060 0.93% 99375.285op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.895µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.916µs 3.918µs 3.920µs 3.922µs 0.19% -1.805 11.665 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254985841.103op/s 255483557.516op/s ± 176237.223op/s 255476451.592op/s ± 86998.799op/s 255557347.479op/s 255733975.209op/s 255914719.044op/s 256724607.817op/s 0.49% 1.827 11.826 0.07% 12461.854op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.555µs 63.869µs ± 0.133µs 63.849µs ± 0.050µs 63.900µs 64.097µs 64.368µs 64.535µs 1.07% 2.008 6.953 0.21% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15495421.695op/s 15657223.630op/s ± 32455.257op/s 15661940.701op/s ± 12232.807op/s 15673528.586op/s 15693959.128op/s 15709989.357op/s 15734310.237op/s 0.46% -1.977 6.810 0.21% 2294.933op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.738µs 57.872µs ± 0.082µs 57.854µs ± 0.025µs 57.885µs 58.087µs 58.182µs 58.226µs 0.64% 2.539 7.279 0.14% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17174349.655op/s 17279688.956op/s ± 24275.684op/s 17285024.340op/s ± 7482.841op/s 17291351.951op/s 17302662.746op/s 17313537.541op/s 17319664.468op/s 0.20% -2.527 7.227 0.14% 1716.550op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.898µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.916µs 3.918µs 3.922µs 3.930µs 0.42% 0.070 6.378 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254429791.966op/s 255491263.882op/s ± 199395.629op/s 255486574.192op/s ± 97679.157op/s 255584208.607op/s 255827416.913op/s 255907277.749op/s 256509338.596op/s 0.40% -0.051 6.365 0.08% 14099.400op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.588µs 54.859µs ± 0.301µs 54.683µs ± 0.058µs 55.084µs 55.523µs 55.822µs 56.199µs 2.77% 1.521 2.331 0.55% 0.021µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17793931.686op/s 18229245.925op/s ± 99327.323op/s 18287273.899op/s ± 19262.235op/s 18301384.501op/s 18308087.323op/s 18316517.306op/s 18319174.680op/s 0.17% -1.488 2.159 0.54% 7023.502op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.974µs 52.200µs ± 0.097µs 52.196µs ± 0.063µs 52.263µs 52.352µs 52.435µs 52.504µs 0.59% 0.264 -0.138 0.19% 0.007µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19046205.698op/s 19157306.928op/s ± 35709.719op/s 19158612.613op/s ± 23064.380op/s 19180953.317op/s 19214734.822op/s 19226947.672op/s 19240526.321op/s 0.43% -0.254 -0.147 0.19% 2525.058op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.428µs 6.549µs ± 0.076µs 6.552µs ± 0.060µs 6.598µs 6.676µs 6.716µs 6.847µs 4.50% 0.576 0.393 1.15% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 146042926.654op/s 152722981.121op/s ± 1755179.480op/s 152620964.698op/s ± 1397594.809op/s 154348667.363op/s 155310554.050op/s 155446321.830op/s 155563159.051op/s 1.93% -0.507 0.183 1.15% 124109.931op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255476939.147op/s; 255526397.136op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.509µs; 82.568µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12111303.719op/s; 12119931.773op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [77.093µs; 77.166µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12959171.670op/s; 12971493.123op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255503778.857op/s; 255552330.974op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [73.913µs; 74.037µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/378282246310005 throughput [13507343.214op/s; 13529928.632op/s] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.136µs; 52.160µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19171725.602op/s; 19180480.591op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.600µs; 6.617µs] or [-0.129%; +0.129%] None None None
credit_card/is_card_number/x371413321323331 throughput [151137833.241op/s; 151527377.202op/s] or [-0.129%; +0.129%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255459132.732op/s; 255507982.301op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.850µs; 63.887µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15652725.643op/s; 15661721.616op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.860µs; 57.883µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17276324.580op/s; 17283053.332op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.914µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255463629.566op/s; 255518898.199op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.817µs; 54.900µs] or [-0.076%; +0.076%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18215480.113op/s; 18243011.737op/s] or [-0.076%; +0.076%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.186µs; 52.213µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19152357.904op/s; 19162255.952op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.538µs; 6.559µs] or [-0.160%; +0.160%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [152479730.126op/s; 152966232.117op/s] or [-0.159%; +0.159%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 53.826ms 54.760ms ± 0.564ms 54.819ms ± 0.501ms 55.268ms 55.483ms 55.762ms 56.177ms 2.48% -0.039 -1.260 1.03% 0.040ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [54.682ms; 54.838ms] or [-0.143%; +0.143%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 44b561d 1741970811 anais/rework-span-links
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.285µs 24.667µs ± 10.150µs 17.559µs ± 0.140µs 33.147µs 43.063µs 44.816µs 84.654µs 382.11% 1.828 6.026 41.05% 0.718µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.261µs; 26.074µs] or [-5.703%; +5.703%] None None None

Baseline

Omitted due to size.

@anais-raison anais-raison force-pushed the anais/rework-span-links branch from be522bf to a1c3d48 Compare March 13, 2025 11:10
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.69%. Comparing base (78f2dfb) to head (44b561d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   72.69%   72.69%           
=======================================
  Files         334      334           
  Lines       50498    50509   +11     
=======================================
+ Hits        36709    36717    +8     
- Misses      13789    13792    +3
Components Coverage Δ
crashtracker 42.87% <ø> (-0.03%) ⬇️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.08% <ø> (ø)
data-pipeline-ffi 90.28% <ø> (ø)
ddcommon 81.05% <ø> (ø)
ddcommon-ffi 66.21% <ø> (ø)
ddtelemetry 61.74% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.59% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.40% <ø> (-0.11%) ⬇️
profiling 81.94% <ø> (ø)
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.63% <ø> (ø)
sidecar-ffi 3.23% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 91.21% <ø> (ø)
trace-mini-agent 74.66% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 96.07% <ø> (ø)
trace-protobuf 78.13% <ø> (ø)
trace-utils 92.91% <95.65%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

VianneyRuhlmann
VianneyRuhlmann approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@VianneyRuhlmann VianneyRuhlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wait for [ APMSP-1674] Support Span Events in Trace Exporter to merge it

@anais-raison anais-raison changed the base branch from main to anais/support-span-events March 13, 2025 14:32
@anais-raison anais-raison force-pushed the anais/rework-span-links branch from 44c90a5 to 6bebc65 Compare March 13, 2025 16:54
Base automatically changed from anais/support-span-events to main March 13, 2025 17:26
@anais-raison anais-raison force-pushed the anais/rework-span-links branch from 6bebc65 to 4c22670 Compare March 14, 2025 09:58
@anais-raison anais-raison force-pushed the anais/rework-span-links branch from 4c22670 to 44b561d Compare March 14, 2025 16:46
@r1viollet
Copy link
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 26.67 MB 26.67 MB -0% (-584 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 84.33 MB 84.32 MB -0% (-1.57 KB) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.60 MB 8.60 MB -0% (-32 B) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 47.49 MB 47.49 MB -0% (-1.32 KB) 👌
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.88 MB 8.88 MB +0% (+112 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 25.33 MB 25.33 MB -0% (-984 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 78.97 MB 78.97 MB -0% (-3.82 KB) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.54 MB 8.54 MB +0% (+24 B) 👌
i686-alpine-linux-musl
Artifact Baseline Commit Change
/i686-alpine-linux-musl/lib/libdatadog_profiling.a 73.11 MB 73.11 MB -0% (-1.61 KB) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so 9.15 MB 9.15 MB 0% (0 B) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so.debug 25.86 MB 25.86 MB -0% (-232 B) 👌
i686-unknown-linux-gnu
Artifact Baseline Commit Change
/i686-unknown-linux-gnu/lib/libdatadog_profiling.a 74.81 MB 74.81 MB -0% (-4.37 KB) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so 9.03 MB 9.03 MB -0% (-160 B) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.52 MB 23.52 MB -0% (-288 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 19.25 MB 19.25 MB -0% (-512 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 54.81 KB 54.81 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 133.67 MB 133.67 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 861.90 MB 861.90 MB -0% (-1.75 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.88 MB 5.88 MB +0% (+512 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 54.81 KB 54.81 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.86 MB 17.86 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 30.16 MB 30.16 MB +0% (+586 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 16.39 MB 16.39 MB -0% (-512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 55.66 KB 55.66 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 135.87 MB 135.84 MB --.01% (-24.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 852.12 MB 852.12 MB -0% (-1.81 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.47 MB 4.47 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 55.66 KB 55.66 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.43 MB 18.43 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 27.69 MB 27.69 MB -0% (-1.35 KB) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 73.11 MB 73.11 MB -0% (-1.61 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.15 MB 9.15 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 25.86 MB 25.86 MB -0% (-232 B) 👌
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 47.49 MB 47.49 MB -0% (-1.32 KB) 👌
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 8.88 MB 8.88 MB +0% (+112 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 74.81 MB 74.81 MB -0% (-4.37 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.03 MB 9.03 MB -0% (-160 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.52 MB 23.52 MB -0% (-288 B) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VianneyRuhlmann VianneyRuhlmann VianneyRuhlmann approved these changes

Assignees
No one assigned
Labels
data-pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anais-raison @codecov-commenter @r1viollet @VianneyRuhlmann