Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(profiling): drop unnecessary mapping ID #925

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

perf(profiling): drop unnecessary mapping ID #925

wants to merge 4 commits into from
+41 −9

Conversation

morrisonlevi
Copy link
Contributor

@morrisonlevi morrisonlevi commented Mar 13, 2025 •
edited
Loading

What does this PR do?

This allows Location.mapping_id=0 in the final pprof, and since that's the default for the field, it can be omitted altogether from the profile.

Motivation

This shrinks every location entry on-wire by a few bytes before compression if the mapping is unused. PHP, Ruby, and Python do not use mappings, so they benefit from this.

Additional Notes

I have not yet validated that the plumbing is all correct, and that the mapping id is completely omitted as desired.

How to test the change?

Describe here in detail how the change can be validated.

@morrisonlevi morrisonlevi added the profiling Relates to the profiling* modules. label Mar 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.76%. Comparing base (78f2dfb) to head (6147a8f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   72.69%   72.76%   +0.07%     
==========================================
  Files         334      334              
  Lines       50498    50941     +443     
==========================================
+ Hits        36709    37067     +358     
- Misses      13789    13874      +85
Components Coverage Δ
crashtracker 42.82% <ø> (-0.08%) ⬇️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.81% <ø> (-0.28%) ⬇️
data-pipeline-ffi 90.28% <ø> (ø)
ddcommon 81.37% <ø> (+0.32%) ⬆️
ddcommon-ffi 66.10% <ø> (-0.11%) ⬇️
ddtelemetry 61.87% <ø> (+0.12%) ⬆️
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.70% <ø> (+0.10%) ⬆️
dogstatsd-client 82.57% <ø> (ø)
ipc 82.41% <ø> (-0.09%) ⬇️
profiling 81.83% <85.29%> (-0.11%) ⬇️
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.97% <ø> (+0.33%) ⬆️
sidecar-ffi 1.17% <ø> (-2.06%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 91.24% <ø> (+0.02%) ⬆️
trace-mini-agent 74.66% <ø> (ø)
trace-normalization 98.24% <ø> (+<0.01%) ⬆️
trace-obfuscation 96.00% <ø> (-0.07%) ⬇️
trace-protobuf 78.13% <ø> (ø)
trace-utils 93.11% <ø> (+0.25%) ⬆️
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter
Copy link

pr-commenter bot commented Mar 14, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-03-15 01:29:23

Comparing candidate commit 6147a8f in PR branch levi/id0 with baseline commit b39c6ee in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 47 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/x371413321323331

  • 🟥 execution_time [+538.119ns; +557.391ns] or [+8.913%; +9.232%]
  • 🟥 throughput [-13982441.851op/s; -13537513.500op/s] or [-8.442%; -8.173%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟥 execution_time [+521.335ns; +543.310ns] or [+8.634%; +8.998%]
  • 🟥 throughput [-13649479.685op/s; -13141882.504op/s] or [-8.242%; -7.935%]

scenario:sql/obfuscate_sql_string

  • 🟥 execution_time [+3.108µs; +3.200µs] or [+4.701%; +4.841%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 147.238µs 148.401µs ± 0.352µs 148.402µs ± 0.195µs 148.560µs 148.945µs 149.294µs 150.124µs 1.16% 0.445 3.157 0.24% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [148.352µs; 148.450µs] or [-0.033%; +0.033%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.860µs 33.525µs ± 1.193µs 32.970µs ± 0.066µs 33.122µs 36.090µs 36.118µs 36.796µs 11.60% 1.695 0.927 3.55% 0.084µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.359µs; 33.690µs] or [-0.493%; +0.493%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.671µs 209.109µs ± 0.164µs 209.117µs ± 0.112µs 209.214µs 209.368µs 209.405µs 209.623µs 0.24% -0.017 0.149 0.08% 0.012µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4770477.107op/s 4782189.580op/s ± 3743.681op/s 4782021.512op/s ± 2562.876op/s 4784805.531op/s 4788218.365op/s 4790898.573op/s 4792237.215op/s 0.21% 0.022 0.147 0.08% 264.718op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.238µs 18.321µs ± 0.038µs 18.318µs ± 0.029µs 18.349µs 18.379µs 18.399µs 18.409µs 0.50% -0.049 -0.607 0.21% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54320512.019op/s 54583349.991op/s ± 113560.787op/s 54591926.498op/s ± 86328.909op/s 54656736.803op/s 54769437.703op/s 54827766.359op/s 54832064.132op/s 0.44% 0.057 -0.605 0.21% 8029.960op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.665µs 10.727µs ± 0.022µs 10.727µs ± 0.016µs 10.744µs 10.761µs 10.770µs 10.773µs 0.43% -0.258 -0.297 0.20% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 92826311.261op/s 93220830.039op/s ± 191239.302op/s 93223678.396op/s ± 136141.560op/s 93350081.315op/s 93573589.046op/s 93677162.948op/s 93765800.439op/s 0.58% 0.268 -0.286 0.20% 13522.661op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.087µs; 209.132µs] or [-0.011%; +0.011%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4781670.742op/s; 4782708.418op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.315µs; 18.326µs] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54567611.558op/s; 54599088.423op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.724µs; 10.730µs] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/good throughput [93194326.111op/s; 93247333.967op/s] or [-0.028%; +0.028%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.981µs 5.044µs ± 0.039µs 5.050µs ± 0.041µs 5.067µs 5.097µs 5.102µs 5.133µs 1.65% -0.129 -1.181 0.77% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.039µs; 5.050µs] or [-0.107%; +0.107%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.178µs 3.208µs ± 1.500µs 3.009µs ± 0.025µs 3.030µs 3.658µs 13.931µs 16.743µs 456.41% 7.554 58.595 46.66% 0.106µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.000µs; 3.416µs] or [-6.483%; +6.483%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 246.902ns 254.350ns ± 9.704ns 250.330ns ± 2.142ns 254.132ns 279.040ns 287.652ns 290.371ns 16.00% 2.111 3.607 3.81% 0.686ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.005ns; 255.695ns] or [-0.529%; +0.529%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.900µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.919µs 3.931µs 0.43% 0.112 9.299 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254393262.113op/s 255488358.497op/s ± 180249.761op/s 255479676.608op/s ± 73637.520op/s 255550547.933op/s 255807749.513op/s 255944744.768op/s 256406448.075op/s 0.36% -0.089 9.239 0.07% 12745.583op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.581µs 82.004µs ± 0.214µs 81.955µs ± 0.130µs 82.145µs 82.378µs 82.575µs 82.921µs 1.18% 0.922 1.361 0.26% 0.015µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12059730.858op/s 12194677.488op/s ± 31757.792op/s 12201868.716op/s ± 19291.008op/s 12216210.300op/s 12233587.986op/s 12253844.705op/s 12257799.201op/s 0.46% -0.903 1.295 0.26% 2245.615op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.372µs 77.009µs ± 0.351µs 76.966µs ± 0.195µs 77.148µs 77.593µs 78.023µs 78.836µs 2.43% 1.471 4.308 0.46% 0.025µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12684497.232op/s 12985685.484op/s ± 58867.230op/s 12992745.601op/s ± 32976.992op/s 13027431.863op/s 13056423.533op/s 13077835.472op/s 13093764.447op/s 0.78% -1.416 4.017 0.45% 4162.542op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.898µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.920µs 3.922µs 0.19% -1.439 8.124 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254992683.925op/s 255512391.080op/s ± 164680.518op/s 255489028.341op/s ± 64185.925op/s 255568686.454op/s 255821354.544op/s 255910438.557op/s 256568469.000op/s 0.42% 1.454 8.217 0.06% 11644.671op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.921µs 73.969µs ± 0.481µs 73.948µs ± 0.328µs 74.313µs 74.753µs 74.889µs 75.532µs 2.14% 0.182 -0.133 0.65% 0.034µs 1 200
credit_card/is_card_number/378282246310005 throughput 13239407.525op/s 13519815.465op/s ± 87874.988op/s 13523041.051op/s ± 59935.341op/s 13575573.251op/s 13660027.745op/s 13698055.267op/s 13713455.532op/s 1.41% -0.147 -0.174 0.65% 6213.700op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.968µs 52.187µs ± 0.107µs 52.181µs ± 0.071µs 52.266µs 52.346µs 52.455µs 52.615µs 0.83% 0.384 0.486 0.20% 0.008µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19005819.443op/s 19162041.273op/s ± 39301.446op/s 19164197.447op/s ± 26240.725op/s 19187330.607op/s 19227936.467op/s 19236728.015op/s 19242597.338op/s 0.41% -0.370 0.453 0.20% 2779.032op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.434µs 6.585µs ± 0.069µs 6.586µs ± 0.047µs 6.636µs 6.703µs 6.740µs 6.749µs 2.48% 0.082 -0.409 1.05% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 148162963.012op/s 151868085.484op/s ± 1595652.400op/s 151844732.796op/s ± 1091332.169op/s 152813652.801op/s 154515690.842op/s 155353233.439op/s 155412577.787op/s 2.35% -0.033 -0.410 1.05% 112829.663op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.887µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.917µs 3.920µs 3.931µs 0.45% -2.182 30.866 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254394095.668op/s 255537136.386op/s ± 198368.382op/s 255530214.701op/s ± 59649.720op/s 255584977.999op/s 255784951.731op/s 255886253.574op/s 257244460.941op/s 0.67% 2.247 31.254 0.08% 14026.763op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.479µs 63.868µs ± 0.148µs 63.852µs ± 0.053µs 63.908µs 64.220µs 64.327µs 64.572µs 1.13% 1.361 3.999 0.23% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15486671.106op/s 15657312.635op/s ± 36287.571op/s 15661269.680op/s ± 12928.240op/s 15673890.825op/s 15709636.859op/s 15732356.393op/s 15753312.360op/s 0.59% -1.333 3.908 0.23% 2565.919op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.398µs 57.529µs ± 0.089µs 57.512µs ± 0.027µs 57.539µs 57.740µs 57.903µs 57.938µs 0.74% 2.555 7.643 0.15% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17259738.733op/s 17382725.484op/s ± 26660.635op/s 17387824.178op/s ± 8074.193op/s 17395274.139op/s 17410883.115op/s 17415282.226op/s 17422215.066op/s 0.20% -2.541 7.571 0.15% 1885.192op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.918µs 3.920µs 3.928µs 0.38% -0.289 5.914 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254559006.399op/s 255534935.528op/s ± 212076.567op/s 255528171.031op/s ± 104379.696op/s 255649436.222op/s 255854544.577op/s 255921107.543op/s 256725561.881op/s 0.47% 0.309 5.959 0.08% 14996.078op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.569µs 54.820µs ± 0.267µs 54.685µs ± 0.059µs 55.037µs 55.284µs 55.621µs 55.890µs 2.20% 1.550 2.115 0.49% 0.019µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17892431.873op/s 18241797.947op/s ± 88248.639op/s 18286421.423op/s ± 19759.511op/s 18300757.194op/s 18317514.108op/s 18322956.851op/s 18325523.790op/s 0.21% -1.525 1.992 0.48% 6240.121op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.877µs 52.143µs ± 0.093µs 52.142µs ± 0.053µs 52.193µs 52.289µs 52.396µs 52.468µs 0.62% 0.466 0.996 0.18% 0.007µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19059342.056op/s 19178081.286op/s ± 34201.000op/s 19178388.833op/s ± 19344.545op/s 19198339.824op/s 19228854.631op/s 19249294.666op/s 19276541.363op/s 0.51% -0.451 0.975 0.18% 2418.376op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.430µs 6.571µs ± 0.079µs 6.556µs ± 0.049µs 6.628µs 6.719µs 6.748µs 6.795µs 3.65% 0.367 -0.335 1.20% 0.006µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 147159701.656op/s 152216682.823op/s ± 1824067.466op/s 152531375.113op/s ± 1146007.966op/s 153503579.688op/s 155313469.881op/s 155492239.227op/s 155513171.996op/s 1.95% -0.312 -0.390 1.20% 128981.047op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255463377.614op/s; 255513339.381op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.974µs; 82.033µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12190276.163op/s; 12199078.812op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [76.961µs; 77.058µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12977527.052op/s; 12993843.916op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255489567.944op/s; 255535214.216op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [73.902µs; 74.035µs] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/378282246310005 throughput [13507636.836op/s; 13531994.093op/s] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.172µs; 52.202µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19156594.470op/s; 19167488.075op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.576µs; 6.595µs] or [-0.146%; +0.146%] None None None
credit_card/is_card_number/x371413321323331 throughput [151646943.408op/s; 152089227.560op/s] or [-0.146%; +0.146%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255509644.436op/s; 255564628.336op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.848µs; 63.889µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15652283.526op/s; 15662341.743op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.516µs; 57.541µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17379030.576op/s; 17386420.391op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255505543.755op/s; 255564327.300op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.783µs; 54.857µs] or [-0.068%; +0.068%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18229567.534op/s; 18254028.360op/s] or [-0.067%; +0.067%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.130µs; 52.156µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19173341.357op/s; 19182821.216op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.560µs; 6.581µs] or [-0.167%; +0.167%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [151963884.616op/s; 152469481.031op/s] or [-0.166%; +0.166%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 53.971ms 54.338ms ± 0.300ms 54.233ms ± 0.138ms 54.495ms 54.855ms 55.288ms 55.811ms 2.91% 1.568 3.331 0.55% 0.021ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [54.297ms; 54.380ms] or [-0.077%; +0.077%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.210µs 505.559µs ± 0.423µs 505.599µs ± 0.262µs 505.838µs 506.139µs 506.427µs 506.472µs 0.17% -0.412 0.160 0.08% 0.030µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1974443.462op/s 1978009.643op/s ± 1653.838op/s 1977853.969op/s ± 1023.290op/s 1978986.789op/s 1980768.531op/s 1982623.775op/s 1983301.483op/s 0.28% 0.417 0.167 0.08% 116.944op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.359µs 453.395µs ± 0.354µs 453.420µs ± 0.223µs 453.622µs 453.974µs 454.113µs 454.288µs 0.19% -0.271 -0.098 0.08% 0.025µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2201245.333op/s 2205582.923op/s ± 1722.533op/s 2205461.208op/s ± 1084.568op/s 2206681.728op/s 2208651.227op/s 2209517.691op/s 2210634.078op/s 0.23% 0.275 -0.095 0.08% 121.801op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.686µs 176.720µs ± 0.299µs 176.773µs ± 0.171µs 176.937µs 177.121µs 177.209µs 177.306µs 0.30% -0.839 0.550 0.17% 0.021µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5639955.425op/s 5658688.594op/s ± 9599.950op/s 5656982.259op/s ± 5478.972op/s 5663342.079op/s 5677778.076op/s 5683732.956op/s 5691968.438op/s 0.62% 0.849 0.571 0.17% 678.819op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.524µs 37.656µs ± 0.043µs 37.656µs ± 0.030µs 37.686µs 37.733µs 37.752µs 37.773µs 0.31% 0.039 -0.012 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26474013.831op/s 26556065.332op/s ± 30660.890op/s 26556391.765op/s ± 21432.032op/s 26577664.456op/s 26603820.813op/s 26624123.746op/s 26649276.464op/s 0.35% -0.032 -0.010 0.12% 2168.052op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.190µs 48.318µs ± 0.113µs 48.308µs ± 0.033µs 48.344µs 48.391µs 48.457µs 49.738µs 2.96% 10.076 124.718 0.23% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20105319.890op/s 20696523.252op/s ± 47167.503op/s 20700600.047op/s ± 13929.173op/s 20713179.490op/s 20733014.552op/s 20747946.011op/s 20751173.620op/s 0.24% -9.900 121.789 0.23% 3335.246op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.500µs; 505.618µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1977780.437op/s; 1978238.849op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.346µs; 453.444µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2205344.196op/s; 2205821.649op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.678µs; 176.761µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5657358.133op/s; 5660019.054op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.650µs; 37.662µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26551816.028op/s; 26560314.637op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.302µs; 48.333µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20689986.290op/s; 20703060.214op/s] or [-0.032%; +0.032%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 69.028µs 69.263µs ± 0.247µs 69.241µs ± 0.059µs 69.299µs 69.386µs 69.558µs 72.527µs 4.75% 11.578 150.232 0.36% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [69.228µs; 69.297µs] or [-0.049%; +0.049%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.418µs 2.443µs ± 0.014µs 2.442µs ± 0.009µs 2.450µs 2.472µs 2.478µs 2.479µs 1.51% 0.722 -0.002 0.58% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.441µs; 2.445µs] or [-0.081%; +0.081%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.979ms 5.994ms ± 0.011ms 5.993ms ± 0.003ms 5.996ms 6.001ms 6.061ms 6.077ms 1.41% 5.136 32.019 0.19% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.992ms; 5.996ms] or [-0.026%; +0.026%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6147a8f 1742001382 levi/id0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.573µs 25.241µs ± 10.536µs 17.728µs ± 0.110µs 33.157µs 42.398µs 53.126µs 93.077µs 425.02% 2.191 9.345 41.64% 0.745µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.781µs; 26.701µs] or [-5.785%; +5.785%] None None None

Baseline

Omitted due to size.

@morrisonlevi
perf(profiling): drop unnecessary mapping ID
87bcfbd 
This allows Location.mapping_id=0 in the final pprof, and since that's
the default for the field, it can be omitted altogether from the
profile. This shrinks every location entry on-wire by a few bytes
before compression.
@morrisonlevi
fix(profiling): fuzz test assumption about mapping_id=0
a2a0de3
@r1viollet
Copy link
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 84.33 MB 84.32 MB -0% (-528 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.60 MB 8.60 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 26.67 MB 26.67 MB 0% (0 B) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 47.49 MB 47.49 MB +0% (+472 B) 👌
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.88 MB 8.88 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 25.33 MB 25.33 MB +0% (+120 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 78.97 MB 78.97 MB +0% (+224 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.54 MB 8.54 MB 0% (0 B) 👌
i686-alpine-linux-musl
Artifact Baseline Commit Change
/i686-alpine-linux-musl/lib/libdatadog_profiling.a 73.11 MB 73.12 MB +0% (+2.28 KB) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so 9.15 MB 9.15 MB 0% (0 B) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so.debug 25.86 MB 25.86 MB +0% (+720 B) 👌
i686-unknown-linux-gnu
Artifact Baseline Commit Change
/i686-unknown-linux-gnu/lib/libdatadog_profiling.a 74.81 MB 74.81 MB +0% (+1.89 KB) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so 9.03 MB 9.03 MB 0% (0 B) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.52 MB 23.52 MB +0% (+672 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 19.25 MB 19.25 MB +0% (+1.50 KB) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 54.81 KB 54.81 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 133.67 MB 133.69 MB +.01% (+24.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 861.90 MB 862.15 MB +.02% (+249.91 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.88 MB 5.88 MB +0% (+512 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 54.81 KB 54.81 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.86 MB 17.86 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 30.16 MB 30.16 MB +0% (+246 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 16.39 MB 16.39 MB +0% (+1.50 KB) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 55.66 KB 55.66 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 135.87 MB 135.90 MB +.02% (+32.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 852.12 MB 853.13 MB +.11% (+1.00 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.47 MB 4.47 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 55.66 KB 55.66 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.43 MB 18.43 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 27.69 MB 27.69 MB +0% (+184 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 73.11 MB 73.12 MB +0% (+2.28 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.15 MB 9.15 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 25.86 MB 25.86 MB +0% (+720 B) 👌
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 47.49 MB 47.49 MB +0% (+472 B) 👌
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 8.88 MB 8.88 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 74.81 MB 74.81 MB +0% (+1.89 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.03 MB 9.03 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.52 MB 23.52 MB +0% (+672 B) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
profiling Relates to the profiling* modules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morrisonlevi @codecov-commenter @r1viollet