Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: VS CMake Generator Finder can Now Find MSVS 2019+ Automatically #32

Conversation

diefbell-grabcad
Copy link
Contributor

If a newer version of Visual Studio build tools (>= 2019) is installed then the automatic build tools finder fails because cmake -G outputs:

Generators
* Visual Studio 17 2022        = Generates Visual Studio 2022 project files.
                                 Use -A option to specify architecture.
  Visual Studio 16 2019        = Generates Visual Studio 2019 project files.
                                 Use -A option to specify architecture.
  Visual Studio 15 2017 [arch] = Generates Visual Studio 2017 project files.
                                 Optional [arch] can be "Win64" or "ARM".
  Visual Studio 14 2015 [arch] = Generates Visual Studio 2015 project files.

and the function GET_CMAKE_VS_GENERATOR doesn't recognise them because it expects the [arch] suffix.

This fixes:
- Above issue;
- Issue where one of the build tools is prefixed by * (I think that means it's the system default or something? Idk;)
- For the build tools that don't end with [arch], it appends -A arch to the generator string in the argumentBuilder (kinda janky).

@aminya
Copy link
Collaborator

aminya commented Dec 1, 2024

Still waiting on getting access to npm before reviewing new PRs.

@diefbell-grabcad
Copy link
Contributor Author

@aminya is this in a position to be merged yet?

@aminya
Copy link
Collaborator

aminya commented Jan 9, 2025

@aminya is this in a position to be merged yet?

I was hoping that @martin31821 would give me access to npm so that I can publish the package. I'll try to reach out again.

@diefbell-grabcad
Copy link
Contributor Author

Would it be worth putting it into your fork and updating ZeroMQ to use that in the meantime?

@diefbell-grabcad
Copy link
Contributor Author

And chance of getting this in the @aminya / forks? This stuff might block me soon. I can reopen the PRs on there?

@aminya aminya merged commit 0f6a169 into EmbeddedEnterprises:master Feb 18, 2025
8 checks passed
@aminya
Copy link
Collaborator

aminya commented Feb 18, 2025

@diefbell-grabcad I can merge it myself. I'll probably publish to aminya/cmake-ts from this repo.

@martin31821 told me he had lost the 2FA keys for npm, so we're out of luck in updating the original package unless the npm support helps.

@diefbell-grabcad
Copy link
Contributor Author

Yeah that'd be great, then can PR it into zeromq 👍

@diefbell-grabcad
Copy link
Contributor Author

@aminya I apparently can't create the PR but here's the diff https://github.com/aminya/cmake-ts/compare/aminya:master...EmbeddedEnterprises:master?expand=1

@aminya
Copy link
Collaborator

aminya commented Mar 21, 2025

@diefbell-grabcad Good news! I finally got access to npm. I have published all the changes under v0.4.0. Will update zeromq shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants