Updated MAUI bindings to use new Compiled Bindings introduced in .NET 9 #630
Conversation
prathameshnarkhede
commented
Mar 21, 2025
prathameshnarkhede
commented
- This pull request updates the MAUI bindings in Toolkit to leverage the new Compiled Bindings feature introduced in .NET 9.
- The changes include replacing existing bindings with compiled bindings for improved performance and type safety.
| @@ -152,7 +152,7 @@ private static void Attachment_Tapped(object? sender, EventArgs e) | |||
| return parent as PopupViewer; | |||
| } | |||
|
|
|||
| private class AttachmentViewModel : System.ComponentModel.INotifyPropertyChanged | |||
| internal class AttachmentViewModel : System.ComponentModel.INotifyPropertyChanged | |||
There was a problem hiding this comment.
Had to make this internally accessible to make use of compiled binding.
| @@ -56,7 +56,7 @@ static FloorFilter() | |||
| VerticalOptions = LayoutOptions.Fill, | |||
| InputTransparent = false, | |||
| }; | |||
| textLabel.SetBinding(Label.TextProperty, "ShortName"); | |||
| textLabel.SetBinding(Label.TextProperty, static (FloorLevel level) => level.ShortName); | |||
There was a problem hiding this comment.
You can delete the dynamicdependency attributes above since you've replaced them all with coded bindings
| @@ -125,8 +125,8 @@ protected override void OnApplyTemplate() | |||
| { | |||
| PART_LevelListView.ItemTemplate = LevelDataTemplate; | |||
| PART_LevelListView.BindingContext = this; | |||
| PART_LevelListView.SetBinding(CollectionView.ItemsSourceProperty, new Binding(nameof(DisplayLevels), BindingMode.OneWay)); | |||
| PART_LevelListView.SetBinding(CollectionView.SelectedItemProperty, new Binding(nameof(SelectedLevel), BindingMode.TwoWay)); | |||
| PART_LevelListView.SetBinding(CollectionView.ItemsSourceProperty, nameof(DisplayLevels), BindingMode.OneWay); | |||
There was a problem hiding this comment.
I don't quite get the purpose of this change? Where's the static method?
There was a problem hiding this comment.
I just moved the code out of new Binding. But It can not be made static expression due to DisplayLevels have private set method.
| @@ -40,25 +40,25 @@ static Legend() | |||
| s_DefaultLayerItemTemplate = new DataTemplate(() => | |||
| { | |||
| var nameLabel = new Label { FontSize = 18, VerticalOptions = LayoutOptions.Center }; | |||
| nameLabel.SetBinding(Label.TextProperty, $"{nameof(LegendEntry.Content)}.{nameof(Layer.Name)}"); | |||
| nameLabel.SetBinding(Label.TextProperty, static (Layer layer) => layer.Name); | |||
There was a problem hiding this comment.
Judging from the code this takes the LegendEntry as parameter, and returns the entry.Content.Name property if I'm not mistaken.
Testing the legend it doesn't render anything either.
| return nameLabel; | ||
| }); | ||
|
|
||
| s_DefaultSublayerItemTemplate = new DataTemplate(() => | ||
| { | ||
| var nameLabel = new Label { FontSize = 14, VerticalOptions = LayoutOptions.Center }; | ||
| nameLabel.SetBinding(Label.TextProperty, $"{nameof(LegendEntry.Content)}.{nameof(ILayerContent.Name)}"); | ||
| nameLabel.SetBinding(Label.TextProperty, static (ILayerContent content) => content.Name); |
There was a problem hiding this comment.
same here - I think the datacontext is a LegendEntry
| symbol.SetBinding(SymbolDisplay.SymbolProperty, static (LegendInfo info) => info.Symbol); | ||
| sl.Children.Add(symbol); | ||
| var nameLabel = new Label { FontSize = 12, VerticalOptions = LayoutOptions.Center }; | ||
| nameLabel.SetBinding(Label.TextProperty, $"{nameof(LegendEntry.Content)}.{nameof(LegendInfo.Name)}"); | ||
| nameLabel.SetBinding(Label.TextProperty, static (LegendInfo info) => info.Name); |
There was a problem hiding this comment.
And here too.
Also remove dynamic dependency attributes at top of method if they are no longer required
| @@ -50,15 +50,15 @@ static OverviewMap() | |||
| IsAttributionTextVisible = false | |||
| }; | |||
| ActivityIndicator activity = new ActivityIndicator(); | |||
| activity.SetBinding(ActivityIndicator.IsRunningProperty, new Binding("Map.LoadStatus", converter: converter, converterParameter: "Loading", source : mapView)); | |||
| activity.SetBinding(ActivityIndicator.IsRunningProperty, static (Map map) => map.LoadStatus, converter: converter, converterParameter: "Loading", source: mapView); | |||
There was a problem hiding this comment.
If the source is the MapView, how can the parameter be a map? Setting a breakpoint here never gets hit, but if I change it to MapView it'll hit the delegate.
Same for the ones below
