[BUGFIX] Fix Audio/Visual Offset causing skips on song start

[xenkap]

Starting the song previously utilized combinedOffset to offset where in the song the instrumental starts in.
This is no longer the case, instead using instrumentalOffset for starting.

The Conductor and Countdown classes have been altered to reflect this behavior.

function startSong also no longer uses resyncVocals().
It was kind of pointless being there, and needing to play the instrumental before calling it makes the audio double up sometimes and it sounds awful

Does this PR close any issues? If so, link them below.

[TBA, but quick searches about offset don't show much]

Briefly describe the issue(s) fixed.

Audio used to skip forward when negative values of Audio/Visual Offset were present. This is now fixed, along with ugly audio doubling behavior on start.

Include any relevant screenshots or videos.

BEFORE:

2024-10-19.17-06-43.mp4

AFTER:

2024-10-19.17-04-39.mp4

(recorded on -210ms audio/visual offset. yes my headphones are that bad, yes they are bluetooth)

[xenkap]

Currently a weird awkward pause after the countdown before the song plays. Currently investigating

[xenkap]

okay all good :yippe:

[xenkap]

added footage :D

[xenkap]

Not sure if this is an issue on my end specifically, but after switching to Linux I've found myself using positive visual offset.
It seems to have an awkward pause at the end of the countdown like it did before-- can someone else see if this happens to them too?
NOTE: Also check if this is a linux-exclusive issue?????? Seems like it happens on any input offset...

Also, squashing these commits. Kinda messy
Having an unreasonably difficult time trying to squash these. Why on earth is GH Desktop so buggy on Linux??
(probably because it isn't officially supported...)

[NotHyper-474]

#3039 should be linked to this

[Squiddu]

don't know entirely if this fixes everything recorded in the issue, but thank GOD someone else noticed something was wrong, thank you i am free

[JackXson-Real]

Just did some testing, and it works flawlessly! Can't wait for this one to be merged. It's been a pain in the ass dealing with this issue.

[Hundrec]

Tested this and it does resolve the skipping on start!
Offsets are still far from playable for me, but this makes it a little better :)

[EliteMasterEric]

Just tested this out on Eggnog Erect like in the example, the audio skip is resolved but I can't hit Boyfriend's first down note! It just doesn't respond to inputs at all.

[Hundrec]

Just tested this out on Eggnog Erect like in the example, the audio skip is resolved but I can't hit Boyfriend's first down note! It just doesn't respond to inputs at all.

Yeah, I encountered this issue consistently when I tested it a few weeks ago
After some discussion with @JackXson-Real, we decided this PR fixed the issue as promised, though it leaves notes at the beginning of the song impossible to hit.

[JackXson-Real]

Just tested this out on Eggnog Erect like in the example, the audio skip is resolved but I can't hit Boyfriend's first down note! It just doesn't respond to inputs at all.

This PR fixes the issue with the audio skipping exclusively. The issue with high input offset on Eggnog Erect exists on the develop branch as well, so it was not an issue introduced by this PR. I believe this should be merged as is and then hopefully someone can make a PR that fixes that issue.