Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename “Auto Pause” Preference to “Pause on Unfocus” #4346

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Rename “Auto Pause” Preference to “Pause on Unfocus” #4346

wants to merge 3 commits into from

Conversation

JackXson-Real
Copy link

@JackXson-Real JackXson-Real commented Mar 18, 2025 •
edited
Loading

Does this PR close any issues? If so, link them below.

Closes #4342

Briefly describe the issue(s) fixed.

Renamed the Auto Pause preference to Pause on Unfocus so that it is actually comprehensible without reading the description.

Include any relevant screenshots or videos.

image

@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. labels Mar 18, 2025
@Hundrec Hundrec added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Mar 18, 2025
@JackXson-Real JackXson-Real changed the base branch from develop to main March 18, 2025 07:16
@JackXson-Real JackXson-Real changed the base branch from main to develop March 18, 2025 07:16
@JackXson-Real JackXson-Real changed the base branch from develop to main March 18, 2025 07:17
@JackXson-Real JackXson-Real changed the base branch from main to develop March 18, 2025 07:18
@JackXson-Real
Copy link
Author

First PR I'm so done bro 💀 I took way too long to figure this out

@JackXson-Real JackXson-Real mentioned this pull request Mar 18, 2025
Closed
@JackXson-Real JackXson-Real changed the title Rename Auto Pause to Pause on Unfocus Rename “Auto Pause” Preference to “Pause on Unfocus” Mar 18, 2025
Lasercar
Lasercar approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@Lasercar Lasercar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give this guy the Contributor label

Hundrec
Hundrec approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally had no idea what this setting did until now

@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Mar 18, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.0 (Pit Stop 2) milestone Mar 18, 2025
@EliteMasterEric EliteMasterEric self-assigned this Mar 18, 2025
EliteMasterEric
EliteMasterEric approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@EliteMasterEric EliteMasterEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, apparently a bunch of people didn't understand this option before the change so I approve

AbnormalPoof
AbnormalPoof approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peak

NotHyper-474
NotHyper-474 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@NotHyper-474 NotHyper-474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congrats on your first contribution!

charlesisfeline
charlesisfeline approved these changes Mar 18, 2025
View reviewed changes
Copy link

@charlesisfeline charlesisfeline left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pr and it already looks good

@trayfellow
Copy link

I always thought this option would just pause your game automatically when it felt like it lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

@NotHyper-474 NotHyper-474 NotHyper-474 approved these changes

@charlesisfeline charlesisfeline charlesisfeline approved these changes

@Lasercar Lasercar Lasercar approved these changes

@AbnormalPoof AbnormalPoof AbnormalPoof approved these changes

@Hundrec Hundrec Hundrec approved these changes

Assignees

@EliteMasterEric EliteMasterEric

Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.

Enhancement: Rename Auto Pause Preference
8 participants
@JackXson-Real @trayfellow @EliteMasterEric @NotHyper-474 @charlesisfeline @Lasercar @AbnormalPoof @Hundrec