Add freebsd generic syscall templates #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arusekk
requested changes
Mar 13, 2019
There was a problem hiding this comment.
Thanks a lot for contributing, freebsd is becoming more and more popular, and as such it should be addressed by pwntools.
There is a couple of minor issues that need to be addressed, but generally it would be awesome if you could reduce the code duplication that happens already. Not saying that it is a must-have, but I would do this (reviving these files' modularity) anyway a moment after your PR gets merged.
zachriggle
requested changes
Mar 13, 2019
Co-Authored-By: io12 <[email protected]>
Co-Authored-By: io12 <[email protected]>
Co-Authored-By: io12 <[email protected]>
Co-Authored-By: io12 <[email protected]>
Co-Authored-By: io12 <[email protected]>
Co-Authored-By: io12 <[email protected]>
Co-Authored-By: io12 <[email protected]>
Arusekk
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the suggestion in #1284, add
pwnlib.shellcraft.<arch>.freebsd.syscall(), as a generic interface for FreeBSD syscalls.