fix: split current iterm window during gdb.debug process #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that I decreased the coverage. Do you want me to write some tests for it? It seems a bit complicated to test... 😕 |
peace-maker
requested changes
Jan 31, 2024
teddav
force-pushed
the
gdb-dbg-mac-iterm
branch
2 times, most recently
from
a3465bb to
242bb20
Compare
teddav
force-pushed
the
gdb-dbg-mac-iterm
branch
from
242bb20 to
5fe63fe
Compare
peace-maker
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "improves" the current gdb.debug on mac for people using iTerm. Currently, gdb.debug returns an error because it can't figure out how to split the terminal and run the
gdbprocess. Best option so far was to use tmux. This PR fixes it and allows to run gdb in the current window by splitting the terminal in 2.Related to #2329
If/when this is merged, the next step would be to do the same for Vscode which would probably be useful to a lot of people.
This might need to be tested by someone else before merging. It works for me but my local setup is a bit messy as I do not have gdb/gdbserver installed, I'm running a docker container and pwntools (which runs on localhost) executes the gdb/gdbserver commands within the docker container. (If you want more details, I can write a quick script to show how to reproduce this setup)