Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RETURN_CONST as an allowed _const_code in safeeval #2352

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

erikleffler
Copy link
Contributor

On my m1 mac, with python 3.12.1, evaluating safeeval.const('1') requires 'RETURN_CONST' as an allowed opcode. I added this opcode to allowed opcodes, and also changed some error mesage generation in ssh.process() (which is where the problem occured for me). I removed the python.recvall() call in the error message generation, since this caused everything to hang for me in a very confusing way, but I can re-add it if you want me to.

@erikleffler erikleffler changed the title Stable add RETURN_CONST as an allowed _const_code in safeeval Feb 18, 2024
Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'd merge it right away, but the unrelated ssh changes require more work. Please split your contributions up into multiple pull requests next time ❤️

@peace-maker peace-maker enabled auto-merge (squash) February 20, 2024 18:25
@peace-maker
Copy link
Member

Thank you!

@peace-maker peace-maker merged commit 1b47ae1 into Gallopsled:stable Feb 20, 2024
10 checks passed
@erikleffler erikleffler deleted the stable branch February 21, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants