Don't go through a shell in gdb.debug
#2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdbserver starts a shell and runs the target process through it. This behavior was added in gdbserver 8.0 together with the commandline flag --no-startup-with-shell to disable it.
peace-maker
changed the title
gdb.debuggdb.debug
peace-maker
added a commit
that referenced
this pull request
Apr 21, 2024
Only add it when we don't want to manipulate the environment or argv[0]. This will cause the problem with fish shell to reappear in those cases, but it's another step for compatibility at least. #2378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gdbserver starts a shell and runs the target process through it. This behavior was added in gdbserver 8.0 in 2017 together with the commandline flag
--no-startup-with-shellto disable it. Some shells can be configured to start the target command in a new process instead of replacing itself with it using execve, which confuses gdbserver's signal handling.Fixes #2377