feat: multi shellcraft cmd #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocoa-xu
force-pushed
the
cx-multi-shellcraft-cmd
branch
from
07b55f5 to
631beb7
Compare
|
Yes, this looks nice and I often wanted to draft something like this too |
|
Hi @peace-maker, thanks for the kind reply. I updated the code and added some tests in the CI. Please feel free to let me know if there's anything else I should add to the CI for testing this feature :) |
Arusekk
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a draft PR that allows shellcraft to take multiple commands at a time and generate corresponding output. For example,
I made this feature a while ago but was not sure if you'd like it to be in this tool. If you're interested in this feature, I can write some tests for this feature :)