Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update apport coredump path handling for CorefileFinder #2518

Merged
merged 4 commits into from
Jan 26, 2025
Merged

fix: update apport coredump path handling for CorefileFinder #2518

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6ce0dd
fix: update apport coredump path handling for CorefileFinder
Meetesh-Saini Jan 15, 2025
b742810
chore: update comment on Apport core path handling
Meetesh-Saini Jan 18, 2025
96268a1
Merge branch 'stable' into apport-corefile
peace-maker Jan 26, 2025
3a9100a
Update CHANGELOG
peace-maker Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pwnlib/elf/corefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,7 +1510,18 @@ def apport_coredump(self):
# should be unique enough that we can just glob.

boot_id = read('/proc/sys/kernel/random/boot_id').strip().decode()
path = self.exe.replace('/', '_')

# Use the absolute path of the executable
# Apport uses the executable's path to determine the core dump filename
#
# Reference source:
# https://github.com/canonical/apport/blob/4bbb179b8f92989bf7c1ee3692074f35d70ef3e8/data/apport#L110
# https://github.com/canonical/apport/blob/4bbb179b8f92989bf7c1ee3692074f35d70ef3e8/apport/fileutils.py#L599
#
# Apport calls `get_core_path` with `options.executable_path`, which corresponds to
# the executable's pathname, as specified by the `%E` placeholder
# in the core pattern (see `man core` and `apport --help`).
path = os.path.abspath(self.exe).replace('/', '_').replace('.', '_')

# Format the name
corefile_name = 'core.{path}.{uid}.{boot_id}.{pid}.*'.format(
Expand Down
Loading