Fixed bound on memcpy loop in thumb,arm,aarch64 #2552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There was a +10 years-old out-of-bound error in the
memcpy
implementation of shellcraft for thumb, arm and aarch64: the loop always copied one byte more than instructed inn
.By the way, there also is a problem when we supply an
n
in[2**31;2**32-1]
(since the comparison is signed), and also whenn==0
(one byte is copied nonetheless), but I guess we can leave those bugs for the sake of shellcode's simplicity 🙃Cheers