Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-2540, GSK-2558, GSK-2663] RAG toolset #1735

Merged
merged 107 commits into from
Feb 13, 2024

Conversation

pierlj
Copy link
Member

@pierlj pierlj commented Jan 15, 2024

  • Add the correctness evaluator and associated tests.
  • Add a generator class KnowledgeBaseTestsetGenerator in the giskard/rag module.
  • Add utilities to build a knowledge base inside the generator. This include VectorStore, Document and OpenAIEmbeddings classes. These are highly inspired from langchain, but much simpler.
  • Add tests for all these classes.

@pierlj pierlj requested a review from mattbit January 15, 2024 17:12
Copy link

linear bot commented Jan 15, 2024

Copy link
Member

@mattbit mattbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I will try it out locally before merging.

@pierlj pierlj changed the title [GSK-2540] Add CorrectnessEvaluator [GSK-2558] Add RAG Toolset Jan 17, 2024
Copy link

linear bot commented Jan 17, 2024

@mattbit mattbit changed the title [GSK-2558] Add RAG Toolset [GSK-2540, GSK-2558] RAG toolset Jan 17, 2024
@mattbit mattbit requested a review from luca-martial February 13, 2024 08:43
@Hartorn Hartorn disabled auto-merge February 13, 2024 14:44
@Hartorn Hartorn enabled auto-merge (squash) February 13, 2024 16:09
Copy link

@Hartorn Hartorn merged commit a283b9e into main Feb 13, 2024
16 checks passed
@Hartorn Hartorn deleted the gsk-2540-add-testset-generation-evaluator branch February 13, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants