Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSK 1191 Allow to save scan transformation in Hub catalog #1770

Closed
wants to merge 14 commits into from

Conversation

kevinmessiaen
Copy link
Member

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Copy link

linear bot commented Jan 26, 2024

@kevinmessiaen kevinmessiaen requested review from mattbit, Googleton and rabah-khalek and removed request for Googleton January 26, 2024 08:36
@kevinmessiaen kevinmessiaen marked this pull request as ready for review January 26, 2024 08:36
kevinmessiaen and others added 3 commits January 26, 2024 15:37
@kevinmessiaen kevinmessiaen marked this pull request as draft January 29, 2024 04:04
@kevinmessiaen
Copy link
Member Author

Adding a wrapper function will be more efficient, we would have to rethink the class are heavily impacted with the @transformation_function annotation and the change will be extremely breaking.

@kevinmessiaen kevinmessiaen deleted the GSK-1191 branch February 2, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant