Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-3948] Add numerical perturbation detector #2094

Merged

Conversation

henchaves
Copy link
Member

@henchaves henchaves commented Jan 6, 2025

Description

This PR adds the numerical perturbation detector feature to robustness detector. This PR is still a work in progress.

The detector will perturb the values by 1 percent and then check for errors in classification mode and for regression the model flags any error which is 5% away from the real value. This could be made so that the user can adjust these percentages but for now this is fixed. Review needed on this.

Disclaimer: This is a new PR replacing #2040, which was opened and implemented by @Kranium2002.

Related Issue

#1846

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Copy link

linear bot commented Jan 6, 2025

@henchaves
Copy link
Member Author

Hey @Kranium2002, I closed the old PR (#2040) and opened this new one because I was not being able to format the files

@henchaves henchaves changed the title Feature/gsk 3948 add numerical perturbation detector [GSK-3948] Add numerical perturbation detector Jan 6, 2025
@henchaves henchaves marked this pull request as ready for review January 6, 2025 19:37
@henchaves henchaves self-assigned this Jan 6, 2025
@Kranium2002
Copy link
Contributor

Hey, does this PR need anything else from my side?

@henchaves
Copy link
Member Author

Hey, does this PR need anything else from my side?

Hi @Kranium2002,
I did a lot of refactoring on your original code, so if you want to have a look it would be good!
I pinged our team again to see if a third person is available for reviewing it.

@kevinmessiaen kevinmessiaen merged commit d47ea28 into main Jan 30, 2025
19 checks passed
@kevinmessiaen kevinmessiaen deleted the feature/gsk-3948-add-numerical-perturbation-detector branch January 30, 2025 09:02
@henchaves
Copy link
Member Author

henchaves commented Jan 30, 2025

Thanks a lot for your contribution @Kranium2002! The PR is now merged to main and the new detector will be available already in the next giskard release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants