Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update docker-compose to use project name #657

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abdou6666
Copy link
Member

Motivation

This PR will enable us to switch from different hexabot projects without the need to destroy volumes & lose db data.
image

Fixes # (issue)

Type of change:

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code

@abdou6666 abdou6666 self-assigned this Jan 30, 2025
Copy link
Collaborator

@yassinedorbozgithub yassinedorbozgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Comment on lines 24 to -26
hexabot-frontend:
container_name: frontend
Copy link
Contributor

@marrouchi marrouchi Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will potentially break the nginx config, we need to rename "hexabot-frontend" to "frontend"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I keep the container names in that case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants