-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert json v3 logic #19251
Revert json v3 logic #19251
Conversation
Thanks @apainintheneck! Looks good when 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good. I guess it's possible that some of the code in tap.rb
will end up getting added back, but tbh it's probably just better to have a clean slate and then add things back as they're actually needed. Thanks for checking though!
The `compact:` option got removed from `Cask::Cask#artifacts_list` in 042d6cc.
I was wondering why the tests were running so fast locally. This is my first time doing any extended development on Linux so I didn't realize that the cask tests wouldn't get run. It should be good now as the tests that failed were referencing code that got removed. I'll do a little bit more testing locally and then merge it in. |
Ah, it looks like there's some more cleanup necessary of environment variables and filenames. |
The logic has now been removed in previous commits. This just removes some references to the `HOMEBREW_INTERNAL_JSON_V3` environment variable along with reverting the changes to the `Cachable` class that were originally added in bd72ec8.
I tested that the formulae JSON generation is the same minus the unused JSON v3 file but I wasn't able to test the cask JSON generation locally because I'm on Linux and there are some cask loading errors related to the |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This reverts the JSON v3 changes made as a part of #16410 since that approach stalled and the code is not being used for anything. Homebrew/formulae.brew.sh#1704 will need to get merged in first so that we're not relying on any of the files that are being generated here.
CC: @Rylan12 as some of this logic could potentially be useful for the new approach outlined in #19204 and I don't want to disrupt that work if possible.