chore: OPTIC-1842: Update the css variables for colors to support RGB and drop the primitive prefixes on all variables #7269
+1,637
−749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and drop the primitive prefixes on all variables
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
| --grape_600: var(--color-primitive-grape-600); | ||
| --grape_700: var(--color-primitive-grape-700); | ||
| --grape_800: var(--color-primitive-grape-800); | ||
| --grape_500: var(--color-grape-500); |
There was a problem hiding this comment.
lets remove -grape_500-raw if we're no longer using that
There was a problem hiding this comment.
One thing I have to still figure out, is how we are going to approach the raw values in general. Still sorting that out actually, but also whatever we do there, we have to remember about the other theming that was done against these old raw values.
There was a problem hiding this comment.
ahh ok, sounds like a follow up PR
yyassi-heartex
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
The design tokens required an alignment of the naming used for the css vars, as well as support rbg and transparency values so they will directly work with the upcoming Dark Mode.
Storybook
Added all design tokens to storybook so they can be searched and visualized, so we can continue to iterate components and other design elements collaboratively and with high visibility.