consolidate append=true behavior of MySQL.load
#224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks again for providing and supporting the library.
This is a a suggestion to avoid triggering a warning. If a user calls
MySQL.load
withappend=true
, I think she is likely to assume or know that the table undername
already exists. Hence callingcreatetable
to me doesn't make too much sense. For this, I suggest to put the entire try-catch clasue in the!append
if statement.