Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate append=true behavior of MySQL.load #224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

psteinb
Copy link

@psteinb psteinb commented Mar 14, 2025

Thanks again for providing and supporting the library.

This is a a suggestion to avoid triggering a warning. If a user calls MySQL.load with append=true, I think she is likely to assume or know that the table under name already exists. Hence calling createtable to me doesn't make too much sense. For this, I suggest to put the entire try-catch clasue in the !append if statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant