Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ChunkCodecLibZlib instead of CodecZlib #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use ChunkCodecLibZlib instead of CodecZlib #175

wants to merge 2 commits into from

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Mar 2, 2025

Fixes #152

This also implements in-place decompression for ZlibCompressor.

This is using ChunkCodecLibZlib from https://github.com/nhz2/ChunkCodecs.jl

@nhz2 nhz2 mentioned this pull request Mar 4, 2025
Open
@coveralls
Copy link

coveralls commented Mar 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13680513151

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 85.835%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Compressors/zlib.jl 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
src/Compressors/zlib.jl 1 82.35%
Totals Coverage Status
Change from base Build 13680422725: -0.2%
Covered Lines: 915
Relevant Lines: 1066
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13680513151

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 85.835%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Compressors/zlib.jl 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
src/Compressors/zlib.jl 1 82.35%
Totals Coverage Status
Change from base Build 13680422725: -0.2%
Covered Lines: 915
Relevant Lines: 1066
💛 - Coveralls

@nhz2 nhz2 marked this pull request as ready for review March 5, 2025 19:06
@nhz2 nhz2 requested a review from asinghvi17 March 5, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asinghvi17 asinghvi17 Awaiting requested review from asinghvi17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZlibCompressor seems not to respect compression level
2 participants
@nhz2 @coveralls