Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading complex type and add basic round trip test #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix reading complex type and add basic round trip test #181

wants to merge 1 commit into from

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Mar 7, 2025

This PR adds some basic round trip tests, which caught a bug in how complex numbers are read.

The test/python.jl file tests that zarr-python is able to read data from Zarr.jl. This PR adds some tests that Zarr.jl is able to read data from Zarr.jl.

@coveralls
Copy link

coveralls commented Mar 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13730328096

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.5%) to 88.491%
Totals Coverage Status
Change from base Build 13680422725: 2.5%
Covered Lines: 938
Relevant Lines: 1060
💛 - Coveralls

@nhz2 nhz2 marked this pull request as ready for review March 7, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhz2 @coveralls