Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimension separator as a type parameter #182

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Mar 12, 2025

This replaces #150 by implementing the dimension_separator as a type
parameter.

I also intend to add Zarr specification version as a type parameter in forthcoming commits.

@mkitti
Copy link
Member Author

mkitti commented Mar 12, 2025

cc: @bjarthur @StephanPreibisch

@coveralls
Copy link

coveralls commented Mar 13, 2025

Pull Request Test Coverage Report for Build 13829000977

Details

  • 38 of 51 (74.51%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 85.189%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Storage/dictstore.jl 2 3 66.67%
src/Storage/directorystore.jl 3 4 75.0%
src/Storage/gcstore.jl 2 3 66.67%
src/Storage/http.jl 2 3 66.67%
src/Storage/zipstore.jl 2 3 66.67%
src/ZArray.jl 2 3 66.67%
src/Storage/consolidated.jl 5 7 71.43%
src/metadata.jl 9 11 81.82%
src/Storage/s3store.jl 3 6 50.0%
Totals Coverage Status
Change from base Build 13680422725: -0.8%
Covered Lines: 926
Relevant Lines: 1087

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants