Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Invoke-Expression with Invoke-Item #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danhje
Copy link

@danhje danhje commented Feb 3, 2020

Invoke-Expression gave error on certain versions of PowerShell. Invoke-Item is a better way of opening a file using the default program or action.

Invoke-Expression gave error on certain versions of PowerShell. Invoke-Item is a better way of opening a file using the default program or action.
@KevinMarquette
Copy link
Owner

Thank you for your patience, not sure how I missed this one.

Good call on using Invoke-Item instead. Code looks good as it is, I just need to test it. I don't think I have any tests for that line, so I may add one with a mock before merging.

@moiaune
Copy link

moiaune commented May 31, 2021

Hey, @KevinMarquette!

Have you had time to take a look at this?

@claudio-salvio
Copy link

Hi @KevinMarquette

I think it would be a good change.
I am writing as a reminder.
If you would be so kind as to spend some time on it, we would appreciate it.

🙏Thank you for making this very useful module available.

Best regards
Claudio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants