perf: improve loading performance when large files are in picker #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@marcin-golebiowski can you see if this PR works or crashes for your files? I dont have any local files that would cause such a large JSON object. This should prevent loading of the |
|
No crashes any more. Tested on 38 MB file. I'm wondering if reading all the files is necessary to display them in the My documents window. |
|
That would be also addressed in #3135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
closes #3416
What is in this change?
Adds a conditional way to load/parse file metadata that is placed into the picker by streaming json content when the file is larger than 10MB of content
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes