-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Android Namespace error #166
base: master
Are you sure you want to change the base?
Conversation
Hey @MisterJimson , Could you take a quick look at PR #166r? It support new version Android studio with java Thanks a lot! |
} | ||
|
||
compileSdkVersion 31 | ||
compileSdk = 34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, while I'm not a maintainer of this repo, what is the issue you're encountering, Is it Java 8 warnings after updating to Android Ladybug?
I understand From the experience of current projects i just used the fix on Mac OS
to avoid problems with JAVA using LadyBag |
It's better to update AGP, Gradle, and the dependencies instead of changing the default Android Studio JDK. |
Summary
This PR updates the
build.gradle
file to improve compatibility with the latest Android Gradle Plugin (AGP) and Kotlin version, while also enhancing the project’s structure and testing capabilities.Changes
Updated Plugin and Library Versions:
7.4.2
to8.1.0
.Project Group and Version:
group
andversion
syntax from Groovy-style to Kotlin-style (=
syntax).Repositories:
mavenCentral()
alongsidegoogle()
in bothbuildscript
andallprojects
for broader dependency resolution.Android Configuration:
namespace
configuration to use the Kotlin-style assignment (=
) syntax for AGP compatibility.compileSdk
from31
to34
.minSdk
from16
to21
for improved compatibility with newer libraries.Source Sets Configuration:
sourceSets
to include Kotlin-specific directories:main.java.srcDirs += "src/main/kotlin"
test.java.srcDirs += "src/test/kotlin"
Code Quality and Compatibility:
kotlinOptions
withjvmTarget = JavaVersion.VERSION_1_8
for consistency withcompileOptions
.Impact
JUnitPlatform
and standard logging configurations.