Ensure that direcory volumes have Directory type #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cdesiniotis @tariq1890 we should confirm whether similar changes are required for the GPU Operator. |
elezar
commented
Mar 14, 2025
| hostPath: | ||
| path: /var/lib/kubelet/device-plugins | ||
| type: DirectoryOrCreate |
There was a problem hiding this comment.
Question: Could this also be Directory instead?
There was a problem hiding this comment.
This change ensures that volumes that are expected to be directories have a Directory or DirectoryOrCreate type. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
check-directory-mounts
branch
from
785fc35 to
c3584ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that volumes that are expected to be directories have a Directory or DirectoryOrCreate type.
See https://nvbugspro.nvidia.com/bug/5129540