Refactor toolkit installer #990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
refactor-toolkit-installer
branch
from
b1c8a90 to
15d6c5e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the toolkit installer to prepare for a future change where a single container image is used for the toolkit. Key changes include new implementations for collecting libraries and executables, creating wrappers for executables, centralizing artifact discovery, and removing deprecated container/toolkit files.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/nvidia-ctk-installer/toolkit/installer/executables_test.go | Adds tests for verifying the wrapper rendering of executables. |
| cmd/nvidia-ctk-installer/toolkit/installer/libraries.go | Implements library collection logic with symlink creation. |
| cmd/nvidia-ctk-installer/toolkit/installer/installer.go | Provides the main installer logic including file copying and wrapper creation. |
| cmd/nvidia-ctk-installer/toolkit/installer/executables.go | Implements executable collection and wrapper file generation via templates. |
| cmd/nvidia-ctk-installer/toolkit/installer/artifact-root.go | Introduces an artifact root abstraction for locating libraries and executables. |
| cmd/nvidia-ctk-installer/toolkit/configure.go | Installs and configures the NVIDIA toolkit configuration file. |
| Other files (including mocks, directory creation, and tests) | Update mocks and tests to support the refactored installer logic while cleaning up deprecated code. |
| @@ -0,0 +1,84 @@ | |||
| /** | |||
There was a problem hiding this comment.
is there a reason this license header is different?
There was a problem hiding this comment.
Different from what? The reason is that these changes have been on a branch associated with #602 for some time and I am factoring them out. Will update the header.
| @@ -0,0 +1,169 @@ | |||
| /** | |||
elezar
force-pushed
the
refactor-toolkit-installer
branch
from
772bc62 to
9255c9c
Compare
Since this is running in a contianer the contents of the /etc/nvidia-container-runtime/config.toml file is equivalent to the default config. This change makes it explicit. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
refactor-toolkit-installer
branch
from
9255c9c to
dee62ca
Compare
Signed-off-by: Evan Lezar <[email protected]>
This change moves the generating of a toolkit config to a separate file. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
refactor-toolkit-installer
branch
from
dee62ca to
9660137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes refactor the toolkit installer used from the toolkit contianer.
The goal is to prepare for ##602 where a single container image is used for the toolkit instead of multiple container images.