Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese · 2021-11-29T16:48:50Z

I make available my integration work on zfs, based on the ceph driver.

zfs is for single node and zfs_iscsi for shared

https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git

tinova · 2022-04-25T08:55:17Z

src/fireedge/etc/sunstone/admin/user-tab.yaml

+    enabled: true
+    actions:
+      change_authentication: true
+      update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:01Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:03Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:06Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:08Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:10Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:12Z

src/sunstone/etc/sunstone-views/vcenter/cloud.yaml

+      settings_showback_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:15Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:17Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:19Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:21Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:24Z

src/sunstone/etc/sunstone-views/kvm/admin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:26Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:28Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:30Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:32Z

src/sunstone/etc/sunstone-views/kvm/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:35Z

src/sunstone/etc/sunstone-views/vcenter/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:37Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:39Z

src/sunstone/etc/sunstone-views/vcenter/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:42Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:45Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

Signed-off-by: Mirko Stojiljkovic <[email protected]> Co-authored-by: MarioRobres <[email protected]>

…3469) Signed-off-by: Marco Mancini <[email protected]>

co-authored-by: Marco Mancini <[email protected]>

This fixes error messages in VMs

tinova · 2025-03-16T10:51:04Z

src/fireedge/src/modules/utils/schema.js

+    case USER_INPUT_TYPES.password:
+      return {
+        type: INPUT_TYPES.TEXT,
+        htmlType: type === USER_INPUT_TYPES.password ? 'password' : 'text',


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code may contain a hardcoded secret. We recommend replacing it with AWS Secrets Manager references to enhance security and follow best practices. For more information, please refer OWASP password storage cheat sheet.

tinova · 2025-03-16T10:51:06Z

src/datastore_mad/remotes/restic/restic.rb

+    def resticenv_sh(restic_bin = @restic_bin)
+        env = []
+        env << %(export RESTIC_BIN="#{restic_bin}")
+        env << %(export RESTIC_PASSWORD='#{@passwd}')


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code may contain a hardcoded secret. We recommend replacing it with AWS Secrets Manager references to enhance security and follow best practices. For more information, please refer OWASP password storage cheat sheet.

* Refactors the ´Chartist´ component using the high performance uPlot library. - Implemented zooming & clustering * Exposes new monitoring metrics [CPU_FORECAST, CPU_FORECAST_FAR] Signed-off-by: Victor Hansson <[email protected]>

* Add key -t, --timezone Signed-off-by: Rostyslav Yatsyshyn <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

* Fix derivative calculations * Add padding to better display labels * Add missing pred. metrics Signed-off-by: Victor Hansson <[email protected]>

Co-authored-by: Ruben S. Montero <[email protected]>

…3475)

Use :: to bind the monitor socket to better capture SSH_CLIENT with ::1 using localhost

Signed-off-by: Valentyn Bohdan <[email protected]>

This commits adds the following improvements: * Improving Usability & Consistency in flow documents: - vm_template -> template_id, generic as also VR templates are considered - vm_template_contents -> template_contents, same as above - custom_attrs -> user_inputs, use same name convention as VM Templates - custom_attrs_values -> user_inputs_values, same as above * Easier OneFlow operations - template_contents (old vm_template_contents) is now in JSON format instead of a String. - better error reporting when merging template contents * Role can use Virtual Routers as main element, supporting all role features (user inputs, dependencies and network creation). Related changes: - Role data model structure has been totally refactored to accomodate the new type (vmrole.rb and vrrole.rb) - VR roles use VR OpenNebula API to create associated VMs. - VR HA uses the cardinaility of the role New attributes: - type, new attribute to identify the role type VM or VR - vrouter_ips, floating IP of each network managed - vrouter_id, of the associated VR * Improved Sunstone interface for flows, including support for the new features. co-authored-by: Victor Palma <[email protected]> co-authored-by: Miguel E. Ruiz <[email protected]> co-authored-by: Victor Hansson <[email protected]>

Now dummy drivers are enabled by default in TM and image DS drivers, but not for system DS. This commit enables 'dummy' for the system DS drivers.

Signed-off-by: Jaime Conchello <[email protected]>

rsmontero force-pushed the master branch 4 times, most recently from 0b269ff to b94dad5 Compare December 14, 2021 16:49

rsmontero force-pushed the master branch from 2377a4e to 995f2d1 Compare March 25, 2022 13:00

tinova reviewed Apr 25, 2022

View reviewed changes

rsmontero force-pushed the master branch 2 times, most recently from 9e1985e to d019bd4 Compare April 28, 2022 14:43

rsmontero force-pushed the master branch from e4e6b6c to 04bbc74 Compare July 27, 2022 14:32

rsmontero force-pushed the master branch from 2024f62 to 3f300f3 Compare October 6, 2022 09:08

tinova reviewed Oct 18, 2022

View reviewed changes

paczerny and others added 10 commits March 13, 2025 12:16

F #1550: Fix mem leak in rank scheduler (#3467)

44e1454

F #1550: Fix cluster template scheduling (#3466)

182ae06

L #-: Rubocop 1.74.0

7566f00

F #1550: Support disk and net usage in the objective function (#3457)

3fbf396

Signed-off-by: Mirko Stojiljkovic <[email protected]> Co-authored-by: MarioRobres <[email protected]>

F #1550: Monitoring should respond to start/stop msg (#3471)

8a8e39c

F #6885: No output from the prediction probe when the forecast is 0 (#…

75118a0

…3469) Signed-off-by: Marco Mancini <[email protected]>

F #1550: Add action labeling (#3448)

f207ae6

F #6885: Add lxc forecast probes

8d69503

co-authored-by: Marco Mancini <[email protected]>

M #-: Host State 1 (MONITORING_MONITORED) not used

1287176

F #1550: Do not call scheduler if pools cannot be set

5d6878d

This fixes error messages in VMs

tinova reviewed Mar 16, 2025

View reviewed changes

rsmontero and others added 18 commits March 16, 2025 12:05

B #6985: Prevent race condition errors with keep_empty_bridge

f3da40c

F #6685: Expose pred. monitoring metrics (#3474)

e6cbc18

* Refactors the ´Chartist´ component using the high performance uPlot library. - Implemented zooming & clustering * Exposes new monitoring metrics [CPU_FORECAST, CPU_FORECAST_FAR] Signed-off-by: Victor Hansson <[email protected]>

F #821: Add timezone flag to oneacct utility (#3473)

4b6692f

* Add key -t, --timezone Signed-off-by: Rostyslav Yatsyshyn <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

F #821: Remove defaulting to UTC

f6da7b3

F #6885: Add missing metrics (#3476)

6fcb210

* Fix derivative calculations * Add padding to better display labels * Add missing pred. metrics Signed-off-by: Victor Hansson <[email protected]>

M #-: Update OVMF_UEFIS (#3477)

db1409f

Co-authored-by: Ruben S. Montero <[email protected]>

M #-: Removed reference to non existant file

d87018c

F #1550: Fix history plan_id for migration, fix capacity scheduling (#…

a3275cd

…3475)

B #6986: Update monitord.conf default address

924db5c

Use :: to bind the monitor socket to better capture SSH_CLIENT with ::1 using localhost

F #1550: DRS automation

63c6969

F #1550: Split optimize and place scheduler selection (#3480)

0e1069c

B #6892: Add check for password upper limit (#3460)

bfbc4c1

Signed-off-by: Valentyn Bohdan <[email protected]>

F #1550: sanitize weights and refactor one_drs defaults (#3481)

bd0d225

M #-: Update onecfg files.yaml (#3483)

dfa9f61

M #-: Add dummy as supported system datastore

66043b5

Now dummy drivers are enabled by default in TM and image DS drivers, but not for system DS. This commit enables 'dummy' for the system DS drivers.

F #1550: Fix xml-schema (#3484)

130bd13

B #6975: Support user-input values containing commas (#3482)

73447d6

Signed-off-by: Jaime Conchello <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese commented Nov 29, 2021 •

edited

Loading

tinova Apr 25, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Mar 16, 2025

tinova Mar 16, 2025

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Are you sure you want to change the base?

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Conversation

openmilanese commented Nov 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openmilanese commented Nov 29, 2021 •

edited

Loading