Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch VIM E2E tests to use nightly #2183

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

JustinGrote
Copy link
Collaborator

@JustinGrote JustinGrote commented Oct 2, 2024

The current ubuntu2.19 package breaks E2E tests. Latest VIM works fine, so switching to nightly for testing.

Band-Aid for #2182 but will not close it as we should probably find out what in that 2.19 ubuntu security update broke it, as it is currently being distributed widely and we should make sure it hasn't broken ubuntu VIM users.

@JustinGrote JustinGrote self-assigned this Oct 2, 2024
@JustinGrote JustinGrote changed the title Investigate Investigate/Fix VIM Test Issue Oct 2, 2024
@JustinGrote JustinGrote changed the title Investigate/Fix VIM Test Issue vim-gtk3 8.2.3995-1ubuntu2.19 Broke VIM Tests Oct 2, 2024
@JustinGrote JustinGrote changed the title vim-gtk3 8.2.3995-1ubuntu2.19 Broke VIM Tests Switch VIM E2E tests to use nightly Oct 2, 2024
@JustinGrote JustinGrote marked this pull request as ready for review October 2, 2024 01:14
@JustinGrote JustinGrote requested a review from a team as a code owner October 2, 2024 01:14
@JustinGrote JustinGrote enabled auto-merge October 2, 2024 01:16
@JustinGrote JustinGrote force-pushed the JustinGrote/issue2182 branch from ff63f4b to 6d2ea99 Compare October 2, 2024 21:21
@JustinGrote
Copy link
Collaborator Author

Rebased and ready.

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Justin!

@JustinGrote JustinGrote added this pull request to the merge queue Oct 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
@andyleejordan andyleejordan added this pull request to the merge queue Oct 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
@andyleejordan
Copy link
Member

I wonder why it's passing in the PR but failing in the merge queue?!

@andyleejordan
Copy link
Member

Oh I can answer that. Only the merge queue installs and tests against PowerShell daily (since that takes a bit longer) and that's not currently working.

@andyleejordan andyleejordan merged commit 791039d into main Oct 7, 2024
8 checks passed
@andyleejordan andyleejordan deleted the JustinGrote/issue2182 branch October 7, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants