Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom logger with tslog #4522

Open
2 tasks done
JustinGrote opened this issue Apr 17, 2023 · 1 comment
Open
2 tasks done

Replace custom logger with tslog #4522

JustinGrote opened this issue Apr 17, 2023 · 1 comment
Assignees
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).

Comments

@JustinGrote
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

Prerequisite to: #4441

To implement this feature, this is an opportune time to look at taking a dependency on a proper logging system to allow for more sinks and a more robust operation.

Proposed Design

I have a lot of love for tslog, which is extremely extensible and can be tied into the existing methods to avoid breaking changes.

@andschwa would you have an appetite for taking this dependency or would you prefer to just overhaul the existing implementation?

@JustinGrote JustinGrote added the Issue-Enhancement A feature request (enhancement). label Apr 17, 2023
@ghost ghost added the Needs: Triage Maintainer attention needed! label Apr 17, 2023
@JustinGrote JustinGrote self-assigned this Apr 17, 2023
@SydneyhSmith SydneyhSmith added Area-Logging and removed Needs: Triage Maintainer attention needed! labels Apr 18, 2023
@andyleejordan
Copy link
Member

I'd be totally fine with tslog, it looks nice! Just want to point out that for #4441 we have to wait until our engine is updated to 1.76...and we're a long way from that at 1.67.0. We are tied to the version that Azure Data Studio uses, so don't expect it to change quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

3 participants