Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VS Code engine to 1.79.0 #4641

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Update VS Code engine to 1.79.0 #4641

merged 1 commit into from
Jun 27, 2023

Conversation

andyleejordan
Copy link
Member

Now that Azure Data Studio is doing the same in:
microsoft/azuredatastudio#23482

Now that Azure Data Studio is doing the same in:
microsoft/azuredatastudio#23482
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Build & Release labels Jun 27, 2023
@andyleejordan andyleejordan requested a review from a team June 27, 2023 20:18
@andyleejordan
Copy link
Member Author

@JustinGrote this will unblock #4441 and #4522!

@andyleejordan andyleejordan enabled auto-merge June 27, 2023 20:26
@andyleejordan
Copy link
Member Author

FWIW I don't think this is jumping the gun to merge today as they are clearly updating and we still need to put this through preview and into stable.

@andyleejordan andyleejordan added this pull request to the merge queue Jun 27, 2023
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2023
@andyleejordan andyleejordan added this pull request to the merge queue Jun 27, 2023
Merged via the queue into main with commit 10ba337 Jun 27, 2023
@andyleejordan andyleejordan deleted the andschwa/vscode branch June 27, 2023 21:27
@JustinGrote
Copy link
Collaborator

Huzzah! We'll give this a bit to make sure there's no regressions and maybe I'll get started on the updated logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants