Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ColumnsForm #3280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Feb 19, 2025

Every dashboard has its own setting on how many columns it has

Closes #3243.

I did some digging and this has not been in use since 2016 (c7cebd9)

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.79%. Comparing base (237e1b6) to head (f953ba4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3280      +/-   ##
==========================================
+ Coverage   60.76%   60.79%   +0.03%     
==========================================
  Files         606      606              
  Lines       43794    43774      -20     
  Branches       48       48              
==========================================
+ Hits        26610    26612       +2     
+ Misses      17172    17150      -22     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to set up nav again to be able to test this, so that'll take a while. Codewise it looks fine though.

Every dashboard has its own setting on how many columns it has
@johannaengland johannaengland force-pushed the cleanup/remove-columns-form-preferences branch from 18effa1 to f953ba4 Compare March 7, 2025 09:26
Copy link

sonarqubecloud bot commented Mar 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Setting number of widgets via ColumnsForm in preferences seems to do nothing
2 participants