-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test suite run on tox v4 #401
base: master
Are you sure you want to change the base?
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 4 files 4 suites 1m 48s ⏱️ Results for commit 0e19fe4. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 83 83
Lines 10021 10021
=======================================
Hits 9880 9880
Misses 141 141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
34f477e
to
bfcb6c5
Compare
This was recommended in the tox docs: https://tox.wiki/en/latest/config.html#package
In the case of being in development mode and having set skipdist to true tox4 would not install Zino in the test environment
ae841f8
to
0e19fe4
Compare
|
Scope and purpose
#399 needs to merged first.
Reference links:
https://tox.wiki/en/latest/upgrading.html
Using tox run instead of tox: https://tox.wiki/en/latest/upgrading.html#updating-usage-with-e
Setting package = editable instead of usedevelop = True: https://tox.wiki/en/latest/config.html#package
Conflict when using skipdist = True and usedevelop = True: tox-dev/tox#2730
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.