Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test suite run on tox v4 #401

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

johannaengland
Copy link
Contributor

Scope and purpose

#399 needs to merged first.

Reference links:
https://tox.wiki/en/latest/upgrading.html
Using tox run instead of tox: https://tox.wiki/en/latest/upgrading.html#updating-usage-with-e
Setting package = editable instead of usedevelop = True: https://tox.wiki/en/latest/config.html#package
Conflict when using skipdist = True and usedevelop = True: tox-dev/tox#2730

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
    • not visible to user
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/

@johannaengland johannaengland added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Mar 13, 2025
@johannaengland johannaengland self-assigned this Mar 13, 2025
Copy link

github-actions bot commented Mar 13, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Mar 13, 2025

Test results

    4 files      4 suites   1m 48s ⏱️
  660 tests   660 ✅ 0 💤 0 ❌
2 576 runs  2 572 ✅ 4 💤 0 ❌

Results for commit 0e19fe4.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (bd1cf17) to head (0e19fe4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          83       83           
  Lines       10021    10021           
=======================================
  Hits         9880     9880           
  Misses        141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lunkwill42 lunkwill42 force-pushed the fix/dev-deps-are-not-runtime-deps branch from 34f477e to bfcb6c5 Compare March 13, 2025 15:01
Base automatically changed from fix/dev-deps-are-not-runtime-deps to master March 13, 2025 15:17
In the case of being in development mode and having set skipdist to true tox4 would not install Zino in the test environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant