Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use autocomplete docs example #7959

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

snowystinger
Copy link
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger force-pushed the useAutocomplete-docs-example branch from b68cb41 to 3b008de Compare March 19, 2025 04:31
@rspbot
Copy link

rspbot commented Mar 19, 2025

@rspbot
Copy link

rspbot commented Mar 19, 2025

@rspbot
Copy link

rspbot commented Mar 19, 2025

@snowystinger snowystinger changed the title [WIP]: docs: Use autocomplete docs example docs: Use autocomplete docs example Mar 25, 2025
@rspbot
Copy link

rspbot commented Mar 25, 2025

@rspbot
Copy link

rspbot commented Mar 25, 2025

@rspbot
Copy link

rspbot commented Mar 25, 2025

## API Changes

react-aria-components

/react-aria-components:UNSTABLE_InternalAutocompleteContext

+UNSTABLE_InternalAutocompleteContext {
+  UNTYPED
+}

ListBox,
ListBoxItem,
useFilter,
UNSTABLE_InternalAutocompleteContext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the main thing to determine is whether we want to export this or if we want to change approaches. For example, we could consider providing ListBoxContext and MenuContext instead of having those components consume InternalAutocompleteContext. Not sure which is better. The same kind of thing applies to TextFieldContext and SearchFieldContext and we chose the opposite approach there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good question. I like the idea that users aren't restricted to our components (without basically implementing what is in this page to add/remove other contexts).
I'm not sure why we went the other way on the inputs, do you or @LFDanLu have a short summary of that? Or did it just kind of happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants