Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC | rework styles to leverage BEM classes in rendering #4954

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

castastrophe
Copy link
Contributor

No description provided.

@castastrophe castastrophe force-pushed the castastrophe/demo-bem-class-useage branch from 8934e4e to b137e9c Compare November 25, 2024 17:09
Copy link

github-actions bot commented Nov 25, 2024

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@caseyisonit
Copy link
Collaborator

@castastrophe just going through old PRs and wanted to check if this one is still being worked on or should be closed?

@castastrophe castastrophe force-pushed the castastrophe/demo-bem-class-useage branch from b137e9c to b3b72a7 Compare February 27, 2025 14:07
Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 30a05b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe force-pushed the castastrophe/demo-bem-class-useage branch from b3b72a7 to 5d0ea9d Compare February 27, 2025 14:09
Copy link

Tachometer results

Currently, no packages are changed by this PR...

@castastrophe
Copy link
Contributor Author

@caseyisonit Yes, this is still in discussion as an approach.

@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2025

Pull Request Test Coverage Report for Build 13950308752

Details

  • 69 of 69 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 97.98%

Totals Coverage Status
Change from base Build 13946558795: -0.001%
Covered Lines: 33698
Relevant Lines: 34196

💛 - Coveralls

@castastrophe castastrophe force-pushed the castastrophe/demo-bem-class-useage branch from 5d0ea9d to 3b2a9ef Compare February 27, 2025 14:34
Copy link

github-actions bot commented Feb 27, 2025

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.98 0.98 0.98
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 243.721 kB 229.225 kB 229.125 kB 🏆
Scripts 60.622 kB 54.078 kB 🏆 54.517 kB
Stylesheet 47.175 kB 40.575 kB 40.161 kB 🏆
Document 6.252 kB 5.48 kB 🏆 5.482 kB
Font 126.823 kB 126.614 kB 🏆 126.615 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@castastrophe castastrophe force-pushed the castastrophe/demo-bem-class-useage branch from 3b2a9ef to 30a05b3 Compare March 4, 2025 22:08
@castastrophe castastrophe force-pushed the castastrophe/demo-bem-class-useage branch from 30a05b3 to 57cb637 Compare March 19, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants