-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(combobox): s2 fast follows fix #5202
base: main
Are you sure you want to change the base?
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Pull Request Test Coverage Report for Build 13972361710Details
💛 - Coveralls |
@@ -65,7 +65,7 @@ | |||
"@spectrum-web-components/shared": "1.3.0" | |||
}, | |||
"devDependencies": { | |||
"@spectrum-css/pickerbutton": "6.0.0-s2-foundations.16" | |||
"@spectrum-css/pickerbutton": "6.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rajdeepc After thinking about it some more, I think updating picker button and textfield in this same PR is blowing the scope up a bit too much. I would probably vote to remove those version updates.
Description
Combobox fast follows fixes.
Motivation and context
How has this been tested?
Test case 1
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.