chore(tabs-overflow): convert scrollContent into a protected getter #5212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes TabsOverflow more extensible without any functional changes.
Description
Converts the previously private
scrollContent
into a protected getter so that child classes can override it without introducing changes to the existing behavior of the component.Related issue(s)
Motivation and context
The tabs overflow component explicitly queries for
sp-tabs
in its slot. When child classes extend from TabsOverflow, like we do in one case in Hz, they should be able to override what's being set forscrollContent
so that queries for other elements are possible.How has this been tested?
The existing test suites are passing, indicating no functional regression.
Test case 1
Test case 2
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.