Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tabs-overflow): convert scrollContent into a protected getter #5212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lehelen19
Copy link
Contributor

@lehelen19 lehelen19 commented Mar 18, 2025

Makes TabsOverflow more extensible without any functional changes.

Description

Converts the previously private scrollContent into a protected getter so that child classes can override it without introducing changes to the existing behavior of the component.

Related issue(s)

Motivation and context

The tabs overflow component explicitly queries for sp-tabs in its slot. When child classes extend from TabsOverflow, like we do in one case in Hz, they should be able to override what's being set for scrollContent so that queries for other elements are possible.

How has this been tested?

The existing test suites are passing, indicating no functional regression.

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@coveralls
Copy link
Collaborator

coveralls commented Mar 18, 2025

Pull Request Test Coverage Report for Build 13961603433

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.982%

Totals Coverage Status
Change from base Build 13951857458: 0.001%
Covered Lines: 33676
Relevant Lines: 34174

💛 - Coveralls

@lehelen19 lehelen19 changed the title refactor(tabs-overflow): convert scrollContent into a protected getter chore(tabs-overflow): convert scrollContent into a protected getter Mar 19, 2025
@lehelen19 lehelen19 marked this pull request as ready for review March 19, 2025 16:30
@lehelen19 lehelen19 requested a review from a team as a code owner March 19, 2025 16:30
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: aaede9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants