-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grouped non-major updates #237
base: main
Are you sure you want to change the base?
Conversation
0686c9e
to
03a95e3
Compare
03a95e3
to
1de7d26
Compare
da159d9
to
f3fcf3e
Compare
f3fcf3e
to
6ae80e9
Compare
161d7a1
to
9e16c89
Compare
9e16c89
to
6ee3a11
Compare
b9c67d4
to
10ab6aa
Compare
98f450c
to
006746b
Compare
d4b7a25
to
7088170
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
go.mod (1)
16-21
: Kubernetes and Etcd Client Updates:
The updates togo.etcd.io/etcd/client/v3
,k8s.io/api
,k8s.io/apimachinery
,k8s.io/client-go
,k8s.io/utils
, and inclusion ofsigs.k8s.io/controller-runtime
(v0.20.3) ensure alignment with newer Kubernetes and etcd APIs. Please review that any interactions with these libraries in your operator remain compatible after these upgrades.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
go.sum
is excluded by!**/*.sum
site/package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (13)
.github/workflows/docker-publish.yaml
(2 hunks).github/workflows/helm-publish.yaml
(1 hunks).github/workflows/hugo.yaml
(1 hunks).github/workflows/make-test-e2e.yaml
(1 hunks).github/workflows/make-test.yaml
(1 hunks).github/workflows/nilaway-lint.yaml
(1 hunks).github/workflows/pre-commit.yaml
(1 hunks).github/workflows/release-assets.yaml
(1 hunks).github/workflows/release-drafter.yaml
(1 hunks)Dockerfile
(1 hunks)Makefile
(3 hunks)go.mod
(2 hunks)site/package.json
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (12)
- .github/workflows/hugo.yaml
- Dockerfile
- site/package.json
- .github/workflows/helm-publish.yaml
- .github/workflows/make-test.yaml
- .github/workflows/release-assets.yaml
- .github/workflows/nilaway-lint.yaml
- .github/workflows/release-drafter.yaml
- .github/workflows/pre-commit.yaml
- .github/workflows/docker-publish.yaml
- .github/workflows/make-test-e2e.yaml
- Makefile
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pre-commit
🔇 Additional comments (16)
go.mod (16)
3-5
: Go Version and Toolchain Update:
The Go version directive has been updated togo 1.23.0
and a new toolchain directive (toolchain go1.24.1
) has been added. Please ensure that all associated build and CI workflows have been updated accordingly to use the new Go toolchain.
11-14
: Testing & CLI Dependencies Updated:
The dependencies for testing and CLI enhancement—github.com/onsi/ginkgo/v2
,github.com/onsi/gomega
,github.com/spf13/cobra
, andgithub.com/spf13/pflag
—have been updated. Verify that your test suites and CLI commands continue to work seamlessly with these versions.
26-26
: xxhash Dependency Update:
Thegithub.com/cespare/xxhash/v2
dependency has been updated to versionv2.3.0
. Though a minor release, ensure that any hash-based functionality in the project is tested for compatibility.
32-32
: json-patch v5 Upgrade:
The upgrade ofgithub.com/evanphx/json-patch/v5
tov5.9.11
is noted. Confirm that JSON patching operations—if used anywhere in the project—continue to function correctly with this updated library.
34-34
: CBOR Library Addition/Update:
The indirect dependency forgithub.com/fxamacker/cbor/v2
is now at versionv2.7.0
. If your project leverages CBOR encoding/decoding, it’s a good idea to run a focused test to ensure that behavior remains consistent.
36-36
: OpenAPI JSON Pointer Update:
Thegithub.com/go-openapi/jsonpointer
update tov0.21.0
(from the previous version) should bring minor improvements. Verify that any integration relying on JSON pointer functionality remains stable.
38-38
: OpenAPI Swag Dependency Upgrade:
Updatinggithub.com/go-openapi/swag
tov0.23.0
should help keep documentation generation and related tasks up-to-date. Please test any features that depend on this package.
43-43
: Google Btree Update:
The version forgithub.com/google/btree
is now updated tov1.1.3
. Although typically an indirect dependency, it’s good practice to ensure that any performance optimizations leveraging B-trees are still effective.
47-47
: Google pprof Version Update:
Thegithub.com/google/pprof
package has been bumped up to a build identified by a timestamp (v0.0.0-20241210010833-40e02aabc2ad
). Please ensure that any profiling or debugging workflows depending on pprof behave as expected.
58-58
: Moby Spdystream Upgrade:
The dependency forgithub.com/moby/spdystream
has been updated from an older version tov0.5.0
. This upgrade may offer improved performance or bug fixes. Confirm that any streaming or multiplexing capabilities remain fully operational.
65-68
: Prometheus Dependencies Update:
The Prometheus-related dependencies (github.com/prometheus/client_golang
to v1.19.1,client_model
to v0.6.1,common
to v0.55.0, andprocfs
to v0.15.1) have been updated. These are critical for metrics collection; thorough testing should be done to confirm that your monitoring and alerting setups continue functioning without disruption.
75-75
: Float16 Library Update:
github.com/x448/float16
has been updated to versionv0.8.4
. Verify that any numerical conversions or computations relying on this library yield correct results, especially if using lower-precision floating point representations.
76-77
: Etcd API and Client Package Updates:
Bothgo.etcd.io/etcd/api/v3
andgo.etcd.io/etcd/client/pkg/v3
are now at versionv3.5.19
. Please ensure there are no regressions in the interaction with etcd, particularly in scenarios that involve critical data storage or retrieval.
80-88
: Golang.org/x Dependencies Overhaul:
Multiplegolang.org/x
modules (including exp, net, oauth2, sync, sys, term, text, time, and tools) have been updated. These changes can affect low-level functionality, performance, or OS interactions. A series of regression and integration tests focusing on platform-dependent behavior is highly recommended.
91-95
: Google and gRPC Libraries Updated:
The updates togoogle.golang.org/genproto
(both API and RPC versions),google.golang.org/grpc
(v1.65.0
),google.golang.org/protobuf
(v1.36.1
), andgopkg.in/evanphx/json-patch.v4
(v4.12.0
) are critical, as they may impact API communication and data serialization/deserialization. Validate that any gRPC services or protocol buffers used in your project remain fully compatible.
100-104
:❓ Verification inconclusive
Kubernetes API Extensions and Related Utilities Upgrade:
The following dependencies have been updated:
k8s.io/apiextensions-apiserver
tov0.32.1
k8s.io/klog/v2
tov2.130.1
k8s.io/kube-openapi
to a newer timestamp versionsigs.k8s.io/json
andsigs.k8s.io/structured-merge-diff/v4
(now atv4.4.2
)
These upgrades play a crucial role in ensuring that custom resource definitions and API extensions work correctly with your operator. Please perform end-to-end tests to detect any unnoticed incompatibilities with Kubernetes APIs.
Action Required: Verify Compatibility of Upgraded Kubernetes Dependencies
The
go.mod
file now lists the following updated dependencies:
k8s.io/apiextensions-apiserver v0.32.1
k8s.io/klog/v2 v2.130.1
k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f
sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3
sigs.k8s.io/structured-merge-diff/v4 v4.4.2
These updates—central to ensuring that custom resource definitions and API extensions function correctly—appear in the final state without any residual or removed code. However, given that some dependencies now reference timestamped versions, it’s essential to run comprehensive end-to-end tests to catch any potential incompatibilities with the Kubernetes API.
Please verify these upgrades in your integration testing environment and ensure that no unexpected runtime issues occur.
1284336
to
fab3973
Compare
|
e64da52
to
840c964
Compare
840c964
to
f7099b8
Compare
This PR contains the following updates:
v4.1.7
->v4.2.2
v5.0.1
->v5.4.0
10.4.19
->10.4.21
v4.2.0
->v4.3.0
v3.2.0
->v3.4.0
v5.5.1
->v5.7.0
v3.3.0
->v3.10.0
v2.19.0
->v2.23.2
v1.33.1
->v1.36.2
v1.7.0
->v1.9.1
v1.0.5
->v1.0.6
v1.19.0
->v1.20.0
1.22.4
->1.24.1
v3.5.14
->v3.5.19
1.22.4
->1.24.1
v1.59.1
->v1.64.8
v3.15.2
->v3.17.2
0.127.0
->0.145.0
v1.15.0
->v1.17.1
v0.30.2
->v0.32.3
v0.30.2
->v0.32.3
v0.30.2
->v0.32.3
v0.15.0
->v0.17.2
v0.23.0
->v0.27.0
v1.30.0
->v1.32.3
v1.4.1
->v1.8.0
v4.44.1
->v4.45.1
v1.13.1
->v1.14.2
11.0.0
->11.0.1
v0.74.0
->v0.81.0
v6.0.0
->v6.1.0
v0.18.4
->v0.20.3
v3.5.0
->v3.8.1
Release Notes
actions/checkout (actions/checkout)
v4.2.2
Compare Source
url-helper.ts
now leverages well-known environment variables by @jww3 in https://github.com/actions/checkout/pull/1941isGhes
by @jww3 in https://github.com/actions/checkout/pull/1946v4.2.1
Compare Source
v4.2.0
Compare Source
actions/setup-go (actions/setup-go)
v5.4.0
Compare Source
v5.3.0
Compare Source
What's Changed
@actions/cache
to^4.0.0
by @Link- in https://github.com/actions/setup-go/pull/531New Contributors
Full Changelog: actions/setup-go@v5...v5.3.0
v5.2.0
Compare Source
What's Changed
New Contributors
Full Changelog: actions/setup-go@v5...v5.2.0
v5.1.0
Compare Source
What's Changed
This addresses issues with caching by adding the architecture (arch) to the cache key, ensuring that cache keys are accurate to prevent conflicts.
Note: This change may break previous cache keys as they will no longer be compatible with the new format.
Bug Fixes
isGhes
logic by @jww3 in https://github.com/actions/setup-go/pull/511New Contributors
Full Changelog: actions/setup-go@v5...v5.1.0
v5.0.2
Compare Source
What's Changed
Bug fixes:
Dependency updates:
New Contributors
Full Changelog: actions/setup-go@v5...v5.0.2
postcss/autoprefixer (autoprefixer)
v10.4.21
Compare Source
-moz-
prefix for:placeholder-shown
(by @Marukome0743).v10.4.20
Compare Source
fit-content
prefix for Firefox.azure/setup-helm (azure/setup-helm)
v4.3.0
Compare Source
docker/login-action (docker/login-action)
v3.4.0
Compare Source
Full Changelog: docker/login-action@v3.3.0...v3.4.0
v3.3.0
Compare Source
Full Changelog: docker/login-action@v3.2.0...v3.3.0
docker/metadata-action (docker/metadata-action)
v5.7.0
Compare Source
Full Changelog: docker/metadata-action@v5.6.1...v5.7.0
v5.6.1
Compare Source
Full Changelog: docker/metadata-action@v5.6.0...v5.6.1
v5.6.0
Compare Source
commit_date
global expression by @trim21 in https://github.com/docker/metadata-action/pull/471 https://github.com/docker/metadata-action/pull/475Full Changelog: docker/metadata-action@v5.5.1...v5.6.0
docker/setup-buildx-action (docker/setup-buildx-action)
v3.10.0
Compare Source
Full Changelog: docker/setup-buildx-action@v3.9.0...v3.10.0
v3.9.0
Compare Source
Full Changelog: docker/setup-buildx-action@v3.8.0...v3.9.0
v3.8.0
Compare Source
Full Changelog: docker/setup-buildx-action@v3.7.1...v3.8.0
v3.7.1
Compare Source
uuid
package by @crazy-max in https://github.com/docker/setup-buildx-action/pull/369Full Changelog: docker/setup-buildx-action@v3.7.0...v3.7.1
v3.7.0
Compare Source
buildkitd-flags
if opt-in by @crazy-max in https://github.com/docker/setup-buildx-action/pull/363uuid
package and switch tocrypto
by @crazy-max in https://github.com/docker/setup-buildx-action/pull/366Full Changelog: docker/setup-buildx-action@v3.6.1...v3.7.0
v3.6.1
Compare Source
Full Changelog: docker/setup-buildx-action@v3.6.0...v3.6.1
v3.6.0
Compare Source
Full Changelog: docker/setup-buildx-action@v3.5.0...v3.6.0
v3.5.0
Compare Source
Full Changelog: docker/setup-buildx-action@v3.4.0...v3.5.0
v3.4.0
Compare Source
Full Changelog: docker/setup-buildx-action@v3.3.0...v3.4.0
onsi/ginkgo (github.com/onsi/ginkgo/v2)
v2.23.2
Compare Source
2.23.2
🎉🎉🎉
At long last, some long-standing performance gaps between
ginkgo
andgo test
have been resolved!Ginkgo operates by running
go test -c
to generate test binaries, and then running those binaries. It turns out that the compilation step ofgo test -c
is slower thango test
's compilation step becausego test
strips out debug symbols (ldflags=-w
) whereasgo test -c
does not.Ginkgo now passes the appropriate
ldflags
togo test -c
when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and whenginkgo build
is called explicitly.This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.
v2.23.1
Compare Source
2.23.1
🚨 For users on MacOS 🚨
A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.
Fixes
Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:
a0e52ff
]b799d8d
]This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.
v2.23.0
Compare Source
2.23.0
Ginkgo 2.23.0 adds a handful of methods to
GinkgoT()
to make it compatible with thetesting.TB
interface in Go 1.24.GinkgoT().Context()
, in particular, is a useful shorthand for generating a new context that will clean itself up in aDeferCleanup()
. This has subtle behavior differences from the golang implementation but should make sense in a Ginkgo... um... context.Features
37a511b
]Fixes
7556a86
]4df06c6
]Maintenance
cbcf39a
]9b261ff
]00f19c8
]e98a4df
]60cc4e2
]fea6f2d
]31d7813
]fc3bbd6
]aee0d56
]809a710
]v2.22.2
Compare Source
What's Changed
Full Changelog: onsi/ginkgo@v2.22.1...v2.22.2
v2.22.1
Compare Source
2.22.1
Fixes
Fix CSV encoding
aab3da6
]c09df39
]96a80fc
]43dad69
]Maintenance
c88c634
]4df44bf
]v2.22.0
Compare Source
2.22.0
Features
0fcaa08
]This allows serial tests to be filtered using the
label-filter
Maintenance
Various doc fixes
v2.21.0
Compare Source
2.21.0
Features
a69eb39
]bcab9c8
]Fixes
e548367
]SpecsThatWillBeRun
withSpecsThatWillRun
[
c2c4d3c
]Maintenance
7e65a00
]v2.20.2
[Compare Source](https://redirect.github.com/onsi/gink
Configuration
📅 Schedule: Branch creation - "* * * * 6" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.