Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive unpopular / unsupported destinations #35359

Merged
merged 10 commits into from
Feb 28, 2024

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Feb 16, 2024

More information in the doc. Depends on #35355 and https://github.com/airbytehq/airbyte-platform-internal/pull/11405. Don't merge this until both of these are merged in.

This PR Should not be merged until all comments in the linked doc are resolved.

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 1:07am

@evantahler evantahler force-pushed the evan/archive-destiations branch from e1b7d2a to 239e259 Compare February 16, 2024 21:05
@evantahler evantahler marked this pull request as ready for review February 23, 2024 17:36
@evantahler evantahler requested a review from a team as a code owner February 23, 2024 17:36
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we are sure that archived will not break the platform (comment) if an archived connector makes its way into a registry for any reason.

@evantahler
Copy link
Contributor Author

https://github.com/airbytehq/airbyte-platform-internal/pull/11405 is merged, so this should be ready to go!

Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as PRs resolving the potential breaking of the platform are merged.

Thanks for creating a PR to handle hiding the archived connectors from the UI if they make it into a catalog. Please go ahead and remove them from the LaunchDarkly flag after that is merged!

There is some stuff we could do if we really want to do this right, in that we probably would want to make cloud and oss both aware that all these connectors are archived, so that if a user is using a connector that is now archived, they can see that in their UI. That would however involve releasing all the connectors (potentially new versions since they last hit cloud), cutting an OSS release so that OSS users have that info too. That's probably not ideal, and what we talked about re: one large catalog with all the info about which registries a connector is available in and if a connector is archived, would probably better solve this problem. I don't expect you to do this, but wanted to raise it in case we are wondering why we don't see these connectors as archived in the UI.

@evantahler
Copy link
Contributor Author

/approve-and-merge reason="archiving destinations"

@octavia-approvington
Copy link
Contributor

Approve this
imagine the commander saying yes

@octavia-approvington octavia-approvington merged commit 0a3fe3d into master Feb 28, 2024
25 of 26 checks passed
@octavia-approvington octavia-approvington deleted the evan/archive-destiations branch February 28, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment