-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive unpopular / unsupported destinations #35359
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
e1b7d2a
to
239e259
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until we are sure that archived
will not break the platform (comment) if an archived connector makes its way into a registry for any reason.
airbyte-integrations/connectors/destination-cassandra/metadata.yaml
Outdated
Show resolved
Hide resolved
https://github.com/airbytehq/airbyte-platform-internal/pull/11405 is merged, so this should be ready to go! |
airbyte-integrations/connectors/destination-cassandra/metadata.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as PRs resolving the potential breaking of the platform are merged.
Thanks for creating a PR to handle hiding the archived connectors from the UI if they make it into a catalog. Please go ahead and remove them from the LaunchDarkly flag after that is merged!
There is some stuff we could do if we really want to do this right, in that we probably would want to make cloud and oss both aware that all these connectors are archived, so that if a user is using a connector that is now archived, they can see that in their UI. That would however involve releasing all the connectors (potentially new versions since they last hit cloud), cutting an OSS release so that OSS users have that info too. That's probably not ideal, and what we talked about re: one large catalog with all the info about which registries a connector is available in and if a connector is archived, would probably better solve this problem. I don't expect you to do this, but wanted to raise it in case we are wondering why we don't see these connectors as archived in the UI.
….yaml Co-authored-by: Ella Rohm-Ensing <[email protected]>
/approve-and-merge reason="archiving destinations" |
More information in the doc. Depends on #35355 and https://github.com/airbytehq/airbyte-platform-internal/pull/11405. Don't merge this until both of these are merged in.
This PR Should not be merged until all comments in the linked doc are resolved.