Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Pipedrive: Add incremental sync to organizations stream #50424

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ acceptance_tests:
- name: stages
- name: deal_products
- name: mail
- name: deals
- name: users
- name: persons
- config_path: "secrets/config.json"
expect_records:
path: "integration_tests/expected_records.jsonl"
Expand All @@ -52,7 +55,33 @@ acceptance_tests:
- name: persons

incremental:
bypass_reason: "All incremental streams are empty in sandbox account."
tests:
- config_path: secrets/config.json
configured_catalog_path: integration_tests/configured_catalog.json
future_state:
future_state_path: integration_tests/abnormal_state.json
missing_streams:
- name: deals
bypass_reason: "Stream is empty in sandbox account."
- name: files
bypass_reason: "Stream is empty in sandbox account."
- name: filters
bypass_reason: "Stream is empty in sandbox account."
- name: notes
bypass_reason: "Stream is empty in sandbox account."
- name: activities
bypass_reason: "Stream is empty in sandbox account."
- name: persons
bypass_reason: "Stream is empty in sandbox account."
- name: pipelines
bypass_reason: "Stream is empty in sandbox account."
- name: products
bypass_reason: "Stream is empty in sandbox account."
- name: stages
bypass_reason: "Stream is empty in sandbox account."
- name: users
bypass_reason: "Stream is empty in sandbox account."
skip_comprehensive_incremental_tests: true
full_refresh:
tests:
- config_path: "secrets/config.json"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#
from dataclasses import InitVar, dataclass
from dataclasses import InitVar, dataclass, field
from typing import Any, List, Mapping, Union

import requests
Expand Down Expand Up @@ -41,7 +41,7 @@ class NullCheckedDpathExtractor(RecordExtractor):
nullable_nested_field: Union[InterpolatedString, str]
config: Config
parameters: InitVar[Mapping[str, Any]]
decoder: Decoder = JsonDecoder(parameters={})
decoder: Decoder = field(default_factory=lambda: JsonDecoder(parameters={}))

def __post_init__(self, parameters: Mapping[str, Any]):
self._dpath_extractor = DpathExtractor(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
"type": "STREAM",
"stream": {
"stream_state": {
"update_time": "2217-06-26 21:20:07"
"update_time": "2217-06-26T21:20:07Z"
},
"stream_descriptor": {
"name": "organizations"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,13 @@
"stream": {
"name": "organizations",
"json_schema": {},
"supported_sync_modes": ["full_refresh"]
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["update_time"]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
"sync_mode": "incremental",
"cursor_field": ["update_time"],
"destination_sync_mode": "append"
},
{
"stream": {
Expand Down
Loading
Loading